Nikolay Sivov : ole32: Handle some failures in Inverse() for composite moniker (PVS-Studio).

Alexandre Julliard julliard at wine.codeweavers.com
Fri Mar 13 08:44:26 CDT 2015


Module: wine
Branch: master
Commit: 24dce2b2295ed660d6c3408aedaf44183369eb6e
URL:    http://source.winehq.org/git/wine.git/?a=commit;h=24dce2b2295ed660d6c3408aedaf44183369eb6e

Author: Nikolay Sivov <nsivov at codeweavers.com>
Date:   Fri Mar 13 11:47:55 2015 +0300

ole32: Handle some failures in Inverse() for composite moniker (PVS-Studio).

---

 dlls/ole32/compositemoniker.c | 9 ++++++++-
 1 file changed, 8 insertions(+), 1 deletion(-)

diff --git a/dlls/ole32/compositemoniker.c b/dlls/ole32/compositemoniker.c
index 40d3568..faadca1 100644
--- a/dlls/ole32/compositemoniker.c
+++ b/dlls/ole32/compositemoniker.c
@@ -778,9 +778,16 @@ CompositeMonikerImpl_Inverse(IMoniker* iface,IMoniker** ppmk)
     /* This method returns a composite moniker that consists of the inverses of each of the components */
     /* of the original composite, stored in reverse order */
 
+    *ppmk = NULL;
+
     res=CreateAntiMoniker(&antiMk);
-    res=IMoniker_ComposeWith(iface,antiMk,0,&tempMk);
+    if (FAILED(res))
+        return res;
+
+    res=IMoniker_ComposeWith(iface,antiMk,FALSE,&tempMk);
     IMoniker_Release(antiMk);
+    if (FAILED(res))
+        return res;
 
     if (tempMk==NULL)
 




More information about the wine-cvs mailing list