Nikolay Sivov : ole32: Fix error handling in GetTimeOfLastChange() for item moniker (PVS-Studio).

Alexandre Julliard julliard at wine.codeweavers.com
Fri Mar 20 08:43:19 CDT 2015


Module: wine
Branch: master
Commit: f294ea8333608047dbb18cb924d68b5af68f8a0c
URL:    http://source.winehq.org/git/wine.git/?a=commit;h=f294ea8333608047dbb18cb924d68b5af68f8a0c

Author: Nikolay Sivov <nsivov at codeweavers.com>
Date:   Fri Mar 20 09:41:34 2015 +0300

ole32: Fix error handling in GetTimeOfLastChange() for item moniker (PVS-Studio).

---

 dlls/ole32/itemmoniker.c | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/dlls/ole32/itemmoniker.c b/dlls/ole32/itemmoniker.c
index e8e5d23..eaf76a3 100644
--- a/dlls/ole32/itemmoniker.c
+++ b/dlls/ole32/itemmoniker.c
@@ -601,8 +601,14 @@ static HRESULT WINAPI ItemMonikerImpl_GetTimeOfLastChange(IMoniker* iface,
         /* IMoniker::GetTimeOfLastChange on the pmkToLeft parameter.                                            */
 
         res=CreateGenericComposite(pmkToLeft,iface,&compositeMk);
+        if (FAILED(res))
+            return res;
 
         res=IBindCtx_GetRunningObjectTable(pbc,&rot);
+        if (FAILED(res)) {
+            IMoniker_Release(compositeMk);
+            return res;
+        }
 
         if (IRunningObjectTable_GetTimeOfLastChange(rot,compositeMk,pItemTime)!=S_OK)
 




More information about the wine-cvs mailing list