Jiaxing Wang : regedit: Need 3 bytes of room at end of buffer for \r\n\0 to avoid endless loop.
Alexandre Julliard
julliard at wine.codeweavers.com
Thu Nov 26 11:03:57 CST 2015
Module: wine
Branch: master
Commit: ebacf05258bc5f8db39cc13275e254390569b63d
URL: http://source.winehq.org/git/wine.git/?a=commit;h=ebacf05258bc5f8db39cc13275e254390569b63d
Author: Jiaxing Wang <hello.wjx at gmail.com>
Date: Thu Nov 26 05:22:40 2015 +0100
regedit: Need 3 bytes of room at end of buffer for \r\n\0 to avoid endless loop.
Signed-off-by: Sebastian Lackner <sebastian at fds-team.de>
Signed-off-by: Alexandre Julliard <julliard at winehq.org>
---
programs/regedit/regproc.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/programs/regedit/regproc.c b/programs/regedit/regproc.c
index 643b559..2d766de 100644
--- a/programs/regedit/regproc.c
+++ b/programs/regedit/regproc.c
@@ -641,7 +641,7 @@ static void processRegLinesA(FILE *in, char* first_chars)
/* Do we need to expand the buffer ? */
assert (s >= line && s <= line + lineSize);
size_remaining = lineSize - (s-line);
- if (size_remaining < 2) /* room for 1 character and the \0 */
+ if (size_remaining < 3) /* need at least 3 bytes of room for \r\n\0 */
{
char *new_buffer;
size_t new_size = lineSize + REG_VAL_BUF_SIZE;
More information about the wine-cvs
mailing list