Michael Stefaniuc : msacm32/tests: Remove always true condition ( PVS-Studio).

Alexandre Julliard julliard at wine.codeweavers.com
Wed Oct 14 11:12:50 CDT 2015


Module: wine
Branch: master
Commit: baf0af67ae60cadb5a47f1cd3376514d2d2c32e9
URL:    http://source.winehq.org/git/wine.git/?a=commit;h=baf0af67ae60cadb5a47f1cd3376514d2d2c32e9

Author: Michael Stefaniuc <mstefani at redhat.de>
Date:   Tue Oct 13 23:58:37 2015 +0200

msacm32/tests: Remove always true condition (PVS-Studio).

dd.szShortName is an array of CHAR and not an arbitrary pointer.

Signed-off-by: Michael Stefaniuc <mstefani at redhat.de>
Signed-off-by: Alexandre Julliard <julliard at winehq.org>

---

 dlls/msacm32/tests/msacm.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/dlls/msacm32/tests/msacm.c b/dlls/msacm32/tests/msacm.c
index 0defb33..4c9dca0 100644
--- a/dlls/msacm32/tests/msacm.c
+++ b/dlls/msacm32/tests/msacm.c
@@ -145,7 +145,7 @@ static BOOL CALLBACK DriverEnumProc(HACMDRIVERID hadid,
             "acmDriverDetailsA(): cbStruct = %08x\n", dd.cbStruct);
 
         for (iter = expected_ids; iter->shortname; ++iter) {
-            if (dd.szShortName && !strcmp(iter->shortname, dd.szShortName)) {
+            if (!strcmp(iter->shortname, dd.szShortName)) {
                 /* try alternative product id on mismatch */
                 if (iter->pid_alt && iter->pid != dd.wPid)
                     ok(iter->mid == dd.wMid && iter->pid_alt == dd.wPid,




More information about the wine-cvs mailing list