Michael Stefaniuc : rsaenh/tests: Mark an old behavior as broken ( PVS-Studio).

Alexandre Julliard julliard at wine.codeweavers.com
Wed Oct 28 10:16:14 CDT 2015


Module: wine
Branch: master
Commit: 899207b6c9ac8193467de068a98b6aba5ecefdd7
URL:    http://source.winehq.org/git/wine.git/?a=commit;h=899207b6c9ac8193467de068a98b6aba5ecefdd7

Author: Michael Stefaniuc <mstefani at redhat.de>
Date:   Wed Oct 28 11:22:37 2015 +0100

rsaenh/tests: Mark an old behavior as broken (PVS-Studio).

All newer Windows support salt in their AES provider.

Signed-off-by: Michael Stefaniuc <mstefani at redhat.de>
Signed-off-by: Alexandre Julliard <julliard at winehq.org>

---

 dlls/rsaenh/tests/rsaenh.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/dlls/rsaenh/tests/rsaenh.c b/dlls/rsaenh/tests/rsaenh.c
index 439d253..b7616fc 100644
--- a/dlls/rsaenh/tests/rsaenh.c
+++ b/dlls/rsaenh/tests/rsaenh.c
@@ -1166,8 +1166,8 @@ static void test_aes(int keylen)
 
     /* Does AES provider support salt? */
     result = CryptGetKeyParam(hKey, KP_SALT, NULL, &dwLen, 0);
-    ok((!result && GetLastError() == NTE_BAD_KEY) || result /* Win7 */,
-       "expected NTE_BAD_KEY, got %08x\n", GetLastError());
+    todo_wine ok(result || broken(GetLastError() == NTE_BAD_KEY), /* Vista or older */
+       "Expected OK, got last error %d\n", GetLastError());
     if (result)
         ok(!dwLen, "unexpected salt length %d\n", dwLen);
 




More information about the wine-cvs mailing list