Vincent Povirk : comdlg32: Return success from IFileDialog2::AddPlace.
Alexandre Julliard
julliard at wine.codeweavers.com
Mon Sep 14 09:44:34 CDT 2015
Module: wine
Branch: master
Commit: 4270a8a4dc55e2f99b5d1c721bdfbc778cf9e5f0
URL: http://source.winehq.org/git/wine.git/?a=commit;h=4270a8a4dc55e2f99b5d1c721bdfbc778cf9e5f0
Author: Vincent Povirk <vincent at codeweavers.com>
Date: Wed Sep 9 14:23:55 2015 -0500
comdlg32: Return success from IFileDialog2::AddPlace.
---
dlls/comdlg32/itemdlg.c | 2 +-
dlls/comdlg32/tests/itemdlg.c | 7 ++-----
2 files changed, 3 insertions(+), 6 deletions(-)
diff --git a/dlls/comdlg32/itemdlg.c b/dlls/comdlg32/itemdlg.c
index e9d72cb..8ca3064 100644
--- a/dlls/comdlg32/itemdlg.c
+++ b/dlls/comdlg32/itemdlg.c
@@ -2554,7 +2554,7 @@ static HRESULT WINAPI IFileDialog2_fnAddPlace(IFileDialog2 *iface, IShellItem *p
{
FileDialogImpl *This = impl_from_IFileDialog2(iface);
FIXME("stub - %p (%p, %d)\n", This, psi, fdap);
- return E_NOTIMPL;
+ return S_OK;
}
static HRESULT WINAPI IFileDialog2_fnSetDefaultExtension(IFileDialog2 *iface, LPCWSTR pszDefaultExtension)
diff --git a/dlls/comdlg32/tests/itemdlg.c b/dlls/comdlg32/tests/itemdlg.c
index 5d8e410..45e9776 100644
--- a/dlls/comdlg32/tests/itemdlg.c
+++ b/dlls/comdlg32/tests/itemdlg.c
@@ -778,22 +778,19 @@ static void test_basics(void)
IFileSaveDialog_AddPlace(pfsd, NULL, 0);
}
- todo_wine
- {
hr = IFileOpenDialog_AddPlace(pfod, psidesktop, FDAP_TOP + 1);
- ok(hr == E_INVALIDARG, "got 0x%08x\n", hr);
+ todo_wine ok(hr == E_INVALIDARG, "got 0x%08x\n", hr);
hr = IFileOpenDialog_AddPlace(pfod, psidesktop, FDAP_BOTTOM);
ok(hr == S_OK, "got 0x%08x\n", hr);
hr = IFileOpenDialog_AddPlace(pfod, psidesktop, FDAP_TOP);
ok(hr == S_OK, "got 0x%08x\n", hr);
hr = IFileSaveDialog_AddPlace(pfsd, psidesktop, FDAP_TOP + 1);
- ok(hr == E_INVALIDARG, "got 0x%08x\n", hr);
+ todo_wine ok(hr == E_INVALIDARG, "got 0x%08x\n", hr);
hr = IFileSaveDialog_AddPlace(pfsd, psidesktop, FDAP_BOTTOM);
ok(hr == S_OK, "got 0x%08x\n", hr);
hr = IFileSaveDialog_AddPlace(pfsd, psidesktop, FDAP_TOP);
ok(hr == S_OK, "got 0x%08x\n", hr);
- }
/* SetFileName */
hr = IFileOpenDialog_SetFileName(pfod, NULL);
More information about the wine-cvs
mailing list