Nikolay Sivov : dwrite: Add missing return value check (Coverity).

Alexandre Julliard julliard at winehq.org
Thu Aug 4 17:20:17 CDT 2016


Module: wine
Branch: master
Commit: ff6f31de7625b0fb3d8e73f85fdf3e81a8f3093b
URL:    http://source.winehq.org/git/wine.git/?a=commit;h=ff6f31de7625b0fb3d8e73f85fdf3e81a8f3093b

Author: Nikolay Sivov <nsivov at codeweavers.com>
Date:   Thu Aug  4 10:56:38 2016 +0300

dwrite: Add missing return value check (Coverity).

Signed-off-by: Nikolay Sivov <nsivov at codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard at winehq.org>

---

 dlls/dwrite/font.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/dlls/dwrite/font.c b/dlls/dwrite/font.c
index d1a04db..d354eaf 100644
--- a/dlls/dwrite/font.c
+++ b/dlls/dwrite/font.c
@@ -1596,12 +1596,13 @@ static HRESULT WINAPI dwritefont3_GetFontFaceReference(IDWriteFont3 *iface, IDWr
 static BOOL WINAPI dwritefont3_HasCharacter(IDWriteFont3 *iface, UINT32 ch)
 {
     struct dwrite_font *This = impl_from_IDWriteFont3(iface);
+    HRESULT hr;
     BOOL ret;
 
     TRACE("(%p)->(0x%x)\n", This, ch);
 
-    IDWriteFont_HasCharacter((IDWriteFont*)iface, ch, &ret);
-    return ret;
+    hr = IDWriteFont_HasCharacter((IDWriteFont*)iface, ch, &ret);
+    return hr == S_OK && ret;
 }
 
 static DWRITE_LOCALITY WINAPI dwritefont3_GetLocality(IDWriteFont3 *iface)




More information about the wine-cvs mailing list