Nikolay Sivov : hlink: Handle failure better (Coverity).

Alexandre Julliard julliard at winehq.org
Thu Aug 4 17:20:18 CDT 2016


Module: wine
Branch: master
Commit: 0e486b789d52e4cdb0f861b3eff495e1a5edbd48
URL:    http://source.winehq.org/git/wine.git/?a=commit;h=0e486b789d52e4cdb0f861b3eff495e1a5edbd48

Author: Nikolay Sivov <nsivov at codeweavers.com>
Date:   Thu Aug  4 11:08:26 2016 +0300

hlink: Handle failure better (Coverity).

Signed-off-by: Nikolay Sivov <nsivov at codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard at winehq.org>

---

 dlls/hlink/browse_ctx.c | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/dlls/hlink/browse_ctx.c b/dlls/hlink/browse_ctx.c
index d90aad9..ee8509d 100644
--- a/dlls/hlink/browse_ctx.c
+++ b/dlls/hlink/browse_ctx.c
@@ -106,10 +106,13 @@ static HRESULT WINAPI IHlinkBC_Register(IHlinkBrowseContext* iface,
     IMoniker *mon;
     IMoniker *composite;
     IRunningObjectTable *ROT;
+    HRESULT hr;
 
     FIXME("(%p)->(%i %p %p %p)\n", This, dwReserved, piunk, pimk, pdwRegister);
 
-    CreateItemMoniker(NULL, szIdent, &mon);
+    hr = CreateItemMoniker(NULL, szIdent, &mon);
+    if (FAILED(hr))
+        return hr;
     CreateGenericComposite(mon, pimk, &composite);
 
     GetRunningObjectTable(0, &ROT);




More information about the wine-cvs mailing list