Jacek Caban : rpcrt4/tests: Don't load GetUserNameEx dynamically.
Alexandre Julliard
julliard at winehq.org
Tue Aug 30 10:30:45 CDT 2016
Module: wine
Branch: master
Commit: ffe01b33f1a266aef2ec75e46d23a316750b8211
URL: http://source.winehq.org/git/wine.git/?a=commit;h=ffe01b33f1a266aef2ec75e46d23a316750b8211
Author: Jacek Caban <jacek at codeweavers.com>
Date: Mon Aug 29 17:30:10 2016 +0200
rpcrt4/tests: Don't load GetUserNameEx dynamically.
Signed-off-by: Jacek Caban <jacek at codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard at winehq.org>
---
dlls/rpcrt4/tests/Makefile.in | 2 +-
dlls/rpcrt4/tests/rpc.c | 11 ++---------
dlls/rpcrt4/tests/server.c | 29 ++++++++---------------------
3 files changed, 11 insertions(+), 31 deletions(-)
diff --git a/dlls/rpcrt4/tests/Makefile.in b/dlls/rpcrt4/tests/Makefile.in
index 5df97c4..5229d07 100644
--- a/dlls/rpcrt4/tests/Makefile.in
+++ b/dlls/rpcrt4/tests/Makefile.in
@@ -1,5 +1,5 @@
TESTDLL = rpcrt4.dll
-IMPORTS = ole32 rpcrt4 advapi32
+IMPORTS = ole32 rpcrt4 secur32 advapi32
EXTRAIDLFLAGS = --prefix-server=s_
C_SRCS = \
diff --git a/dlls/rpcrt4/tests/rpc.c b/dlls/rpcrt4/tests/rpc.c
index 81b598c..d260827 100644
--- a/dlls/rpcrt4/tests/rpc.c
+++ b/dlls/rpcrt4/tests/rpc.c
@@ -862,19 +862,12 @@ static void test_RpcServerInqDefaultPrincName(void)
{
RPC_STATUS ret;
RPC_CSTR principal, saved_principal;
- BOOLEAN (WINAPI *pGetUserNameExA)(EXTENDED_NAME_FORMAT,LPSTR,PULONG);
char *username;
ULONG len = 0;
- pGetUserNameExA = (void *)GetProcAddress( LoadLibraryA("secur32.dll"), "GetUserNameExA" );
- if (!pGetUserNameExA)
- {
- win_skip( "GetUserNameExA not exported\n" );
- return;
- }
- pGetUserNameExA( NameSamCompatible, NULL, &len );
+ GetUserNameExA( NameSamCompatible, NULL, &len );
username = HeapAlloc( GetProcessHeap(), 0, len );
- pGetUserNameExA( NameSamCompatible, username, &len );
+ GetUserNameExA( NameSamCompatible, username, &len );
ret = RpcServerInqDefaultPrincNameA( 0, NULL );
ok( ret == RPC_S_UNKNOWN_AUTHN_SERVICE, "got %u\n", ret );
diff --git a/dlls/rpcrt4/tests/server.c b/dlls/rpcrt4/tests/server.c
index 2653f7a..6901f6b 100644
--- a/dlls/rpcrt4/tests/server.c
+++ b/dlls/rpcrt4/tests/server.c
@@ -44,7 +44,6 @@ static void (WINAPI *pNDRSContextMarshall2)(RPC_BINDING_HANDLE, NDR_SCONTEXT, vo
static NDR_SCONTEXT (WINAPI *pNDRSContextUnmarshall2)(RPC_BINDING_HANDLE, void*, ULONG, void*, ULONG);
static RPC_STATUS (WINAPI *pRpcServerRegisterIfEx)(RPC_IF_HANDLE,UUID*, RPC_MGR_EPV*, unsigned int,
unsigned int,RPC_IF_CALLBACK_FN*);
-static BOOLEAN (WINAPI *pGetUserNameExA)(EXTENDED_NAME_FORMAT, LPSTR, PULONG);
static RPC_STATUS (WINAPI *pRpcBindingSetAuthInfoExA)(RPC_BINDING_HANDLE, RPC_CSTR, ULONG, ULONG,
RPC_AUTH_IDENTITY_HANDLE, ULONG, RPC_SECURITY_QOS *);
static RPC_STATUS (WINAPI *pRpcServerRegisterAuthInfoA)(RPC_CSTR, ULONG, RPC_AUTH_KEY_RETRIEVAL_FN, LPVOID);
@@ -60,14 +59,12 @@ static const WCHAR worldW[] = { 'W','o','r','l','d','!',0 };
static void InitFunctionPointers(void)
{
HMODULE hrpcrt4 = GetModuleHandleA("rpcrt4.dll");
- HMODULE hsecur32 = LoadLibraryA("secur32.dll");
pNDRSContextMarshall2 = (void *)GetProcAddress(hrpcrt4, "NDRSContextMarshall2");
pNDRSContextUnmarshall2 = (void *)GetProcAddress(hrpcrt4, "NDRSContextUnmarshall2");
pRpcServerRegisterIfEx = (void *)GetProcAddress(hrpcrt4, "RpcServerRegisterIfEx");
pRpcBindingSetAuthInfoExA = (void *)GetProcAddress(hrpcrt4, "RpcBindingSetAuthInfoExA");
pRpcServerRegisterAuthInfoA = (void *)GetProcAddress(hrpcrt4, "RpcServerRegisterAuthInfoA");
- pGetUserNameExA = (void *)GetProcAddress(hsecur32, "GetUserNameExA");
if (!pNDRSContextMarshall2) old_windows_version = TRUE;
}
@@ -1500,7 +1497,7 @@ void __cdecl s_authinfo_test(unsigned int protseq, int secure)
todo_wine
ok(principal != NULL, "NULL principal\n");
}
- if (protseq == RPC_PROTSEQ_LRPC && principal && pGetUserNameExA)
+ if (protseq == RPC_PROTSEQ_LRPC && principal)
{
int len;
char *spn;
@@ -1548,9 +1545,6 @@ set_auth_info(RPC_BINDING_HANDLE handle)
RPC_STATUS status;
RPC_SECURITY_QOS qos;
- if (!pGetUserNameExA)
- return;
-
qos.Version = 1;
qos.Capabilities = RPC_C_QOS_CAPABILITIES_MUTUAL_AUTH;
qos.IdentityTracking = RPC_C_QOS_IDENTITY_STATIC;
@@ -1709,11 +1703,9 @@ server(void)
if (ncalrpc_status == RPC_S_OK)
{
run_client("ncalrpc_basic");
- if (pGetUserNameExA)
- {
- /* we don't need to register RPC_C_AUTHN_WINNT for ncalrpc */
- run_client("ncalrpc_secure");
- }
+
+ /* we don't need to register RPC_C_AUTHN_WINNT for ncalrpc */
+ run_client("ncalrpc_secure");
}
else
skip("lrpc tests skipped due to earlier failure\n");
@@ -1742,20 +1734,15 @@ server(void)
START_TEST(server)
{
+ ULONG size = 0;
int argc;
char **argv;
InitFunctionPointers();
- if (pGetUserNameExA)
- {
- ULONG size = 0;
- ok(!pGetUserNameExA(NameSamCompatible, NULL, &size), "GetUserNameExA\n");
- domain_and_user = HeapAlloc(GetProcessHeap(), 0, size);
- ok(pGetUserNameExA(NameSamCompatible, domain_and_user, &size), "GetUserNameExA\n");
- }
- else
- win_skip("GetUserNameExA is needed for some authentication tests\n");
+ ok(!GetUserNameExA(NameSamCompatible, NULL, &size), "GetUserNameExA\n");
+ domain_and_user = HeapAlloc(GetProcessHeap(), 0, size);
+ ok(GetUserNameExA(NameSamCompatible, domain_and_user, &size), "GetUserNameExA\n");
argc = winetest_get_mainargs(&argv);
progname = argv[0];
More information about the wine-cvs
mailing list