Nikolay Sivov : xmllite: Allow prefixed element names.

Alexandre Julliard julliard at winehq.org
Fri Dec 9 13:37:34 CST 2016


Module: wine
Branch: master
Commit: 682d4f147ccb2f7b2e77f09ed4e85deaa6c45d2b
URL:    http://source.winehq.org/git/wine.git/?a=commit;h=682d4f147ccb2f7b2e77f09ed4e85deaa6c45d2b

Author: Nikolay Sivov <nsivov at codeweavers.com>
Date:   Fri Dec  9 16:38:32 2016 +0300

xmllite: Allow prefixed element names.

Signed-off-by: Nikolay Sivov <nsivov at codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard at winehq.org>

---

 dlls/xmllite/reader.c       | 4 +---
 dlls/xmllite/tests/reader.c | 3 ++-
 2 files changed, 3 insertions(+), 4 deletions(-)

diff --git a/dlls/xmllite/reader.c b/dlls/xmllite/reader.c
index ef535e6..2dadfa2 100644
--- a/dlls/xmllite/reader.c
+++ b/dlls/xmllite/reader.c
@@ -2233,9 +2233,7 @@ static HRESULT reader_parse_element(xmlreader *reader)
         hr = reader_parse_stag(reader, &prefix, &local, &qname, &empty);
         if (FAILED(hr)) return hr;
 
-        /* FIXME: need to check for defined namespace to reject invalid prefix,
-           currently reject all prefixes */
-        if (prefix.len) return NC_E_UNDECLAREDPREFIX;
+        /* FIXME: need to check for defined namespace to reject invalid prefix */
 
         /* if we got empty element and stack is empty go straight to Misc */
         if (empty && list_empty(&reader->elements))
diff --git a/dlls/xmllite/tests/reader.c b/dlls/xmllite/tests/reader.c
index 3658d52..f9d4821 100644
--- a/dlls/xmllite/tests/reader.c
+++ b/dlls/xmllite/tests/reader.c
@@ -1362,7 +1362,8 @@ static void test_read_element(void)
         if (test->hr_broken)
             ok(hr == test->hr || broken(hr == test->hr_broken), "got %08x for %s\n", hr, test->xml);
         else
-            ok(hr == test->hr, "got %08x for %s\n", hr, test->xml);
+            todo_wine_if(test->hr == NC_E_UNDECLAREDPREFIX)
+                ok(hr == test->hr, "got %08x for %s\n", hr, test->xml);
         if (hr == S_OK)
         {
             const WCHAR *str;




More information about the wine-cvs mailing list