Marcus Meissner : xmllite: Hr was uninitialized in error path (Coverity).

Alexandre Julliard julliard at winehq.org
Tue Dec 20 16:23:24 CST 2016


Module: wine
Branch: master
Commit: f900879d9e86d9f0991be3357e1a3a455b39cc26
URL:    http://source.winehq.org/git/wine.git/?a=commit;h=f900879d9e86d9f0991be3357e1a3a455b39cc26

Author: Marcus Meissner <marcus at jet.franken.de>
Date:   Sat Dec 17 12:37:10 2016 +0100

xmllite: Hr was uninitialized in error path (Coverity).

Signed-off-by: Marcus Meissner <marcus at jet.franken.de>
Signed-off-by: Nikolay Sivov <nsivov at codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard at winehq.org>

---

 dlls/xmllite/reader.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/dlls/xmllite/reader.c b/dlls/xmllite/reader.c
index 0fedd91..460eeab 100644
--- a/dlls/xmllite/reader.c
+++ b/dlls/xmllite/reader.c
@@ -547,8 +547,10 @@ static HRESULT reader_push_element(xmlreader *reader, strval *prefix, strval *lo
     }
 
     element = reader_alloc_zero(reader, sizeof(*element));
-    if (!element)
+    if (!element) {
+        hr = E_OUTOFMEMORY;
         goto failed;
+    }
 
     if ((hr = reader_strvaldup(reader, prefix, &element->prefix)) != S_OK ||
             (hr = reader_strvaldup(reader, localname, &element->localname)) != S_OK ||




More information about the wine-cvs mailing list