Andrew Eikum : dsound: Avoid NULL pointer dereference (Coverity).

Alexandre Julliard julliard at wine.codeweavers.com
Thu Feb 11 09:59:46 CST 2016


Module: wine
Branch: master
Commit: 468477b69410f3f9731b4f9fec568945acb8e1ea
URL:    http://source.winehq.org/git/wine.git/?a=commit;h=468477b69410f3f9731b4f9fec568945acb8e1ea

Author: Andrew Eikum <aeikum at codeweavers.com>
Date:   Wed Feb 10 12:54:04 2016 -0600

dsound: Avoid NULL pointer dereference (Coverity).

Signed-off-by: Andrew Eikum <aeikum at codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard at winehq.org>

---

 dlls/dsound/buffer.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/dlls/dsound/buffer.c b/dlls/dsound/buffer.c
index 2a80c3f..e85a5d1 100644
--- a/dlls/dsound/buffer.c
+++ b/dlls/dsound/buffer.c
@@ -1205,9 +1205,9 @@ HRESULT IDirectSoundBufferImpl_Duplicate(
         HeapFree(GetProcessHeap(),0,dsb->pwfx);
         HeapFree(GetProcessHeap(),0,dsb);
         dsb = NULL;
-    }
+    }else
+        IDirectSoundBuffer8_AddRef(&dsb->IDirectSoundBuffer8_iface);
 
-    IDirectSoundBuffer8_AddRef(&dsb->IDirectSoundBuffer8_iface);
     *ppdsb = dsb;
     return hres;
 }




More information about the wine-cvs mailing list