Hugh McMaster : reg: Fail when / d is used without an accompanying argument.
Alexandre Julliard
julliard at wine.codeweavers.com
Thu Feb 11 09:59:47 CST 2016
Module: wine
Branch: master
Commit: 3c340fda682a7835975bc9644b654149a27d11ec
URL: http://source.winehq.org/git/wine.git/?a=commit;h=3c340fda682a7835975bc9644b654149a27d11ec
Author: Hugh McMaster <hugh.mcmaster at outlook.com>
Date: Thu Feb 11 23:34:22 2016 +1100
reg: Fail when /d is used without an accompanying argument.
Signed-off-by: Hugh McMaster <hugh.mcmaster at outlook.com>
Signed-off-by: Alexandre Julliard <julliard at winehq.org>
---
programs/reg/reg.c | 8 +++++++-
programs/reg/tests/reg.c | 8 ++++----
2 files changed, 11 insertions(+), 5 deletions(-)
diff --git a/programs/reg/reg.c b/programs/reg/reg.c
index 32b0d17..63b518f 100644
--- a/programs/reg/reg.c
+++ b/programs/reg/reg.c
@@ -562,7 +562,13 @@ int wmain(int argc, WCHAR *argvW[])
else if (!lstrcmpiW(argvW[i], slashSW))
separator = argvW[++i][0];
else if (!lstrcmpiW(argvW[i], slashDW))
- data = argvW[++i];
+ {
+ if (!(data = argvW[++i]))
+ {
+ output_message(STRING_INVALID_CMDLINE);
+ return 1;
+ }
+ }
else if (!lstrcmpiW(argvW[i], slashFW))
force = TRUE;
}
diff --git a/programs/reg/tests/reg.c b/programs/reg/tests/reg.c
index 0eaf638..cdf8359 100644
--- a/programs/reg/tests/reg.c
+++ b/programs/reg/tests/reg.c
@@ -169,7 +169,7 @@ static void test_add(void)
verify_reg(hkey, "test", REG_SZ, "", 1, TODO_REG_SIZE);
run_reg_exe("reg add HKCU\\" KEY_BASE " /v test1 /t REG_SZ /f /d", &r);
- todo_wine ok(r == REG_EXIT_FAILURE, "got exit code %d, expected 1\n", r);
+ ok(r == REG_EXIT_FAILURE, "got exit code %d, expected 1\n", r);
run_reg_exe("reg add HKEY_CURRENT_USER\\" KEY_BASE " /ve /d WineTEST /f", &r);
ok(r == REG_EXIT_SUCCESS, "got exit code %d, expected 0\n", r);
@@ -242,7 +242,7 @@ static void test_add(void)
verify_reg(hkey, "bin5", REG_BINARY, buffer, 0, 0);
run_reg_exe("reg add HKCU\\" KEY_BASE " /v bin6 /t REG_BINARY /f /d", &r);
- todo_wine ok(r == REG_EXIT_FAILURE, "got exit code %d, expected 1\n", r);
+ ok(r == REG_EXIT_FAILURE, "got exit code %d, expected 1\n", r);
/* REG_DWORD */
run_reg_exe("reg add HKCU\\" KEY_BASE " /t REG_DWORD /f /d 12345678", &r);
@@ -255,7 +255,7 @@ static void test_add(void)
win_skip("broken reg.exe detected\n");
run_reg_exe("reg add HKCU\\" KEY_BASE " /v dword0 /t REG_DWORD /f /d", &r);
- todo_wine ok(r == REG_EXIT_FAILURE, "got exit code %d, expected 1\n", r);
+ ok(r == REG_EXIT_FAILURE, "got exit code %d, expected 1\n", r);
run_reg_exe("reg add HKCU\\" KEY_BASE " /v dword1 /t REG_DWORD /f", &r);
todo_wine ok(r == REG_EXIT_FAILURE || broken(r == REG_EXIT_SUCCESS /* WinXP */),
"got exit code %d, expected 1\n", r);
@@ -353,7 +353,7 @@ static void test_add(void)
verify_reg(hkey, "multi11", REG_MULTI_SZ, buffer, 3, TODO_REG_SIZE);
run_reg_exe("reg add HKCU\\" KEY_BASE " /v multi12 /t REG_MULTI_SZ /f /d", &r);
- todo_wine ok(r == REG_EXIT_FAILURE, "got exit code %d, expected 1\n", r);
+ ok(r == REG_EXIT_FAILURE, "got exit code %d, expected 1\n", r);
RegCloseKey(hkey);
More information about the wine-cvs
mailing list