Jacek Caban : mshtml: Skip unused named args in Invoke calls.
Alexandre Julliard
julliard at wine.codeweavers.com
Tue Jan 12 12:15:22 CST 2016
Module: wine
Branch: master
Commit: 8a20cf4cf82d005f0cecd786fde201aafd541573
URL: http://source.winehq.org/git/wine.git/?a=commit;h=8a20cf4cf82d005f0cecd786fde201aafd541573
Author: Jacek Caban <jacek at codeweavers.com>
Date: Mon Jan 11 20:49:24 2016 +0100
mshtml: Skip unused named args in Invoke calls.
Signed-off-by: Jacek Caban <jacek at codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard at winehq.org>
---
dlls/mshtml/dispex.c | 3 ++-
dlls/mshtml/tests/script.c | 17 +++++++++++++++++
2 files changed, 19 insertions(+), 1 deletion(-)
diff --git a/dlls/mshtml/dispex.c b/dlls/mshtml/dispex.c
index ff4e28a..3980daf 100644
--- a/dlls/mshtml/dispex.c
+++ b/dlls/mshtml/dispex.c
@@ -617,6 +617,7 @@ static HRESULT dispex_value(DispatchEx *This, LCID lcid, WORD flags, DISPPARAMS
static HRESULT typeinfo_invoke(DispatchEx *This, func_info_t *func, WORD flags, DISPPARAMS *dp, VARIANT *res,
EXCEPINFO *ei)
{
+ DISPPARAMS params = {dp->rgvarg+dp->cNamedArgs, NULL, dp->cArgs-dp->cNamedArgs, 0};
ITypeInfo *ti;
IUnknown *unk;
UINT argerr=0;
@@ -634,7 +635,7 @@ static HRESULT typeinfo_invoke(DispatchEx *This, func_info_t *func, WORD flags,
return E_FAIL;
}
- hres = ITypeInfo_Invoke(ti, unk, func->id, flags, dp, res, ei, &argerr);
+ hres = ITypeInfo_Invoke(ti, unk, func->id, flags, ¶ms, res, ei, &argerr);
IUnknown_Release(unk);
return hres;
diff --git a/dlls/mshtml/tests/script.c b/dlls/mshtml/tests/script.c
index 2511939..73b1185 100644
--- a/dlls/mshtml/tests/script.c
+++ b/dlls/mshtml/tests/script.c
@@ -1926,6 +1926,23 @@ static void test_func(IDispatchEx *obj)
hres = IDispatchEx_Invoke(dispex, DISPID_VALUE, &IID_NULL, LOCALE_NEUTRAL, DISPATCH_METHOD, &dp, &var, &ei, NULL);
ok(hres == S_OK || broken(E_ACCESSDENIED), "InvokeEx failed: %08x\n", hres);
if(SUCCEEDED(hres)) {
+ DISPID named_args[2] = { DISPID_THIS, 0xdeadbeef };
+ VARIANT args[2];
+
+ ok(V_VT(&var) == VT_BSTR, "V_VT(var)=%d\n", V_VT(&var));
+ ok(!strcmp_wa(V_BSTR(&var), "[object]"), "V_BSTR(var) = %s\n", wine_dbgstr_w(V_BSTR(&var)));
+ VariantClear(&var);
+
+ dp.rgdispidNamedArgs = named_args;
+ dp.cNamedArgs = 2;
+ dp.cArgs = 2;
+ dp.rgvarg = &var;
+ V_VT(args) = VT_DISPATCH;
+ V_DISPATCH(args) = (IDispatch*)obj;
+ V_VT(args+1) = VT_I4;
+ V_I4(args+1) = 3;
+ hres = IDispatchEx_Invoke(dispex, DISPID_VALUE, &IID_NULL, LOCALE_NEUTRAL, DISPATCH_METHOD, &dp, &var, &ei, NULL);
+ ok(hres == S_OK, "InvokeEx failed: %08x\n", hres);
ok(V_VT(&var) == VT_BSTR, "V_VT(var)=%d\n", V_VT(&var));
ok(!strcmp_wa(V_BSTR(&var), "[object]"), "V_BSTR(var) = %s\n", wine_dbgstr_w(V_BSTR(&var)));
VariantClear(&var);
More information about the wine-cvs
mailing list