Sebastian Lackner : server: Avoid invalid memory access if creation of namespace fails in create_directory (Coverity).

Alexandre Julliard julliard at wine.codeweavers.com
Mon Jan 25 09:27:58 CST 2016


Module: wine
Branch: master
Commit: 9dab25c12483f7a684686bdb0f82bc523b6b0e82
URL:    http://source.winehq.org/git/wine.git/?a=commit;h=9dab25c12483f7a684686bdb0f82bc523b6b0e82

Author: Sebastian Lackner <sebastian at fds-team.de>
Date:   Sun Jan 24 18:50:56 2016 +0100

server: Avoid invalid memory access if creation of namespace fails in create_directory (Coverity).

Signed-off-by: Sebastian Lackner <sebastian at fds-team.de>
Signed-off-by: Alexandre Julliard <julliard at winehq.org>

---

 server/directory.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/server/directory.c b/server/directory.c
index de049ef..937ab89 100644
--- a/server/directory.c
+++ b/server/directory.c
@@ -192,7 +192,7 @@ static struct directory *create_directory( struct directory *root, const struct
         if (!(dir->entries = create_namespace( hash_size )))
         {
             release_object( dir );
-            dir = NULL;
+            return NULL;
         }
         if (sd) default_set_sd( &dir->obj, sd, OWNER_SECURITY_INFORMATION | GROUP_SECURITY_INFORMATION |
                                 DACL_SECURITY_INFORMATION | SACL_SECURITY_INFORMATION );




More information about the wine-cvs mailing list