Thomas Faber : netapi32: Avoid buffer overrun in NetBTNameEncode.
Alexandre Julliard
julliard at winehq.org
Tue Jul 5 11:07:50 CDT 2016
Module: wine
Branch: master
Commit: f53b2588afcba6b435622bbf542be5fe80672d43
URL: http://source.winehq.org/git/wine.git/?a=commit;h=f53b2588afcba6b435622bbf542be5fe80672d43
Author: Thomas Faber <thomas.faber at reactos.org>
Date: Sun Jun 26 11:02:37 2016 +0200
netapi32: Avoid buffer overrun in NetBTNameEncode.
Signed-off-by: Thomas Faber <thomas.faber at reactos.org>
Signed-off-by: Alexandre Julliard <julliard at winehq.org>
---
dlls/netapi32/nbt.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/dlls/netapi32/nbt.c b/dlls/netapi32/nbt.c
index 0f593d5..207bd66 100644
--- a/dlls/netapi32/nbt.c
+++ b/dlls/netapi32/nbt.c
@@ -171,7 +171,7 @@ static int NetBTNameEncode(const UCHAR *p, UCHAR *buffer)
if (!buffer) return 0;
buffer[len++] = NCBNAMSZ * 2;
- for (i = 0; p[i] && i < NCBNAMSZ; i++)
+ for (i = 0; i < NCBNAMSZ && p[i]; i++)
{
buffer[len++] = ((p[i] & 0xf0) >> 4) + 'A';
buffer[len++] = (p[i] & 0x0f) + 'A';
More information about the wine-cvs
mailing list