Kirill Smirnov : winex11.drv: Fix an uninitialized variable (clang).

Alexandre Julliard julliard at winehq.org
Fri Jul 8 10:02:04 CDT 2016


Module: wine
Branch: master
Commit: 827f97c1ab87c11d38b31e21f593e4d99a954004
URL:    http://source.winehq.org/git/wine.git/?a=commit;h=827f97c1ab87c11d38b31e21f593e4d99a954004

Author: Kirill Smirnov <kirill.k.smirnov at gmail.com>
Date:   Fri Jul  8 01:50:19 2016 +0300

winex11.drv: Fix an uninitialized variable (clang).

dst_bits structure is valid only if copy_image_bits() succeeded.

Signed-off-by: Kirill K. Smirnov <kirill.k.smirnov at gmail.com>
Signed-off-by: Alexandre Julliard <julliard at winehq.org>

---

 dlls/winex11.drv/bitblt.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/dlls/winex11.drv/bitblt.c b/dlls/winex11.drv/bitblt.c
index 8d61a4b..80256dc 100644
--- a/dlls/winex11.drv/bitblt.c
+++ b/dlls/winex11.drv/bitblt.c
@@ -1436,10 +1436,10 @@ static DWORD put_pixmap_image( Pixmap pixmap, const XVisualInfo *vis,
         XPutImage( gdi_display, pixmap, gc, image, 0, 0, 0, 0, coords.width, coords.height );
         XFreeGC( gdi_display, gc );
         image->data = NULL;
+        if (dst_bits.free) dst_bits.free( &dst_bits );
     }
 
     XDestroyImage( image );
-    if (dst_bits.free) dst_bits.free( &dst_bits );
     return ret;
 
 update_format:




More information about the wine-cvs mailing list