Michael Stefaniuc : quartz: Remove redundant NULL checks before CoTaskMemFree().
Alexandre Julliard
julliard at winehq.org
Fri Jul 8 10:02:04 CDT 2016
Module: wine
Branch: master
Commit: b5a7853b861c02f350935813b7503a28d38fa7f6
URL: http://source.winehq.org/git/wine.git/?a=commit;h=b5a7853b861c02f350935813b7503a28d38fa7f6
Author: Michael Stefaniuc <mstefani at redhat.de>
Date: Fri Jul 8 10:10:14 2016 +0200
quartz: Remove redundant NULL checks before CoTaskMemFree().
Signed-off-by: Michael Stefaniuc <mstefani at redhat.de>
Signed-off-by: Alexandre Julliard <julliard at winehq.org>
---
dlls/quartz/avidec.c | 7 ++-----
dlls/quartz/filtermapper.c | 3 +--
dlls/quartz/mpegsplit.c | 3 +--
dlls/quartz/tests/filtermapper.c | 3 +--
4 files changed, 5 insertions(+), 11 deletions(-)
diff --git a/dlls/quartz/avidec.c b/dlls/quartz/avidec.c
index eb9b223..7e29318 100644
--- a/dlls/quartz/avidec.c
+++ b/dlls/quartz/avidec.c
@@ -349,11 +349,8 @@ static HRESULT WINAPI AVIDec_BreakConnect(TransformFilter *tf, PIN_DIRECTION dir
{
if (This->hvid)
ICClose(This->hvid);
- if (This->pBihIn)
- CoTaskMemFree(This->pBihIn);
- if (This->pBihOut)
- CoTaskMemFree(This->pBihOut);
-
+ CoTaskMemFree(This->pBihIn);
+ CoTaskMemFree(This->pBihOut);
This->hvid = NULL;
This->pBihIn = NULL;
This->pBihOut = NULL;
diff --git a/dlls/quartz/filtermapper.c b/dlls/quartz/filtermapper.c
index 6564155..8a1fc3a 100644
--- a/dlls/quartz/filtermapper.c
+++ b/dlls/quartz/filtermapper.c
@@ -609,8 +609,7 @@ static void FM2_DeleteRegFilter(REGFILTER2 * prf2)
for (i = 0; i < prf2->u.s2.cPins2; i++)
{
UINT j;
- if (prf2->u.s2.rgPins2[i].clsPinCategory)
- CoTaskMemFree((LPVOID)prf2->u.s2.rgPins2[i].clsPinCategory);
+ CoTaskMemFree((void*)prf2->u.s2.rgPins2[i].clsPinCategory);
for (j = 0; j < prf2->u.s2.rgPins2[i].nMediaTypes; j++)
{
diff --git a/dlls/quartz/mpegsplit.c b/dlls/quartz/mpegsplit.c
index 1fd8002..9b581e9 100644
--- a/dlls/quartz/mpegsplit.c
+++ b/dlls/quartz/mpegsplit.c
@@ -589,8 +589,7 @@ static HRESULT MPEGSplitter_pre_connect(IPin *iface, IPin *pConnectPin, ALLOCATO
if (FAILED(hr))
{
- if (amt.pbFormat)
- CoTaskMemFree(amt.pbFormat);
+ CoTaskMemFree(amt.pbFormat);
ERR("Could not create pin for MPEG audio stream (%x)\n", hr);
break;
}
diff --git a/dlls/quartz/tests/filtermapper.c b/dlls/quartz/tests/filtermapper.c
index 11b7d39..f044a31 100644
--- a/dlls/quartz/tests/filtermapper.c
+++ b/dlls/quartz/tests/filtermapper.c
@@ -528,8 +528,7 @@ static void test_parse_filter_data(void)
ok(pRegFilter->dwMerit == 0x5fffff,"Incorrect merit returned\n");
out:
- if (pRegFilter)
- CoTaskMemFree(pRegFilter);
+ CoTaskMemFree(pRegFilter);
if (psa)
{
SafeArrayUnaccessData(psa);
More information about the wine-cvs
mailing list