Michael Stefaniuc : msvcrt: Remove redundant NULL checks before free().

Alexandre Julliard julliard at winehq.org
Fri Jul 8 10:02:05 CDT 2016


Module: wine
Branch: master
Commit: dbafbcccfcc49b90afcf849ed55c5fdd13b2fd96
URL:    http://source.winehq.org/git/wine.git/?a=commit;h=dbafbcccfcc49b90afcf849ed55c5fdd13b2fd96

Author: Michael Stefaniuc <mstefani at redhat.de>
Date:   Fri Jul  8 10:09:32 2016 +0200

msvcrt: Remove redundant NULL checks before free().

Signed-off-by: Michael Stefaniuc <mstefani at redhat.de>
Signed-off-by: Piotr Caban <piotr at codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard at winehq.org>

---

 dlls/msvcrt/errno.c | 2 +-
 dlls/msvcrt/file.c  | 3 +--
 2 files changed, 2 insertions(+), 3 deletions(-)

diff --git a/dlls/msvcrt/errno.c b/dlls/msvcrt/errno.c
index 46b1859..893ed7b 100644
--- a/dlls/msvcrt/errno.c
+++ b/dlls/msvcrt/errno.c
@@ -365,7 +365,7 @@ void CDECL MSVCRT__wperror(const MSVCRT_wchar_t* str)
         }
     }
     MSVCRT_perror(buffer);
-    if (buffer) MSVCRT_free(buffer);
+    MSVCRT_free(buffer);
 }
 
 /*********************************************************************
diff --git a/dlls/msvcrt/file.c b/dlls/msvcrt/file.c
index 5a2f1e6..432d5c7 100644
--- a/dlls/msvcrt/file.c
+++ b/dlls/msvcrt/file.c
@@ -3498,8 +3498,7 @@ int CDECL MSVCRT__write(int fd, const void* buf, unsigned int count)
         if (!WriteFile(hand, q, size, &num_written, NULL))
             num_written = -1;
         release_ioinfo(info);
-        if(p)
-            MSVCRT_free(p);
+        MSVCRT_free(p);
         if (num_written != size)
         {
             TRACE("WriteFile (fd %d, hand %p) failed-last error (%d), num_written %d\n",




More information about the wine-cvs mailing list