Ken Thomases : winemac: Remove an unnecessary call to -[ NSView removeFromSuperview].
Alexandre Julliard
julliard at winehq.org
Fri Jun 3 10:03:45 CDT 2016
Module: wine
Branch: master
Commit: 9fbc364ea103239553701aa9a9932e3fdabcfff6
URL: http://source.winehq.org/git/wine.git/?a=commit;h=9fbc364ea103239553701aa9a9932e3fdabcfff6
Author: Ken Thomases <ken at codeweavers.com>
Date: Fri Jun 3 00:06:50 2016 -0500
winemac: Remove an unnecessary call to -[NSView removeFromSuperview].
It's only obliquely documented, but -[NSView addSubview:positioned:relativeTo:]
will remove the view from its old superview if it's changing superviews. If
it's just changing z-order within its current superview, it won't.
This avoids some flicker of OpenGL surfaces being removed and re-added.
Signed-off-by: Ken Thomases <ken at codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard at winehq.org>
---
dlls/winemac.drv/cocoa_window.m | 1 -
1 file changed, 1 deletion(-)
diff --git a/dlls/winemac.drv/cocoa_window.m b/dlls/winemac.drv/cocoa_window.m
index 0b975f2..d3b3c89 100644
--- a/dlls/winemac.drv/cocoa_window.m
+++ b/dlls/winemac.drv/cocoa_window.m
@@ -3354,7 +3354,6 @@ void macdrv_set_view_superview(macdrv_view v, macdrv_view s, macdrv_window w, ma
WineWindow* oldWindow = (WineWindow*)[view window];
WineWindow* newWindow = (WineWindow*)[superview window];
- [view removeFromSuperview];
if (prev)
[superview addSubview:view positioned:NSWindowBelow relativeTo:prev];
else
More information about the wine-cvs
mailing list