Nikolay Sivov : dsound: Remove redundant null pointer check (Coverity).

Alexandre Julliard julliard at winehq.org
Mon Jun 6 10:19:51 CDT 2016


Module: wine
Branch: master
Commit: d597ea8f03027483ca08bb191d9929656992e590
URL:    http://source.winehq.org/git/wine.git/?a=commit;h=d597ea8f03027483ca08bb191d9929656992e590

Author: Nikolay Sivov <nsivov at codeweavers.com>
Date:   Mon Jun  6 11:14:38 2016 +0300

dsound: Remove redundant null pointer check (Coverity).

IAudioClient instance could be expected to be valid at this point.

Signed-off-by: Nikolay Sivov <nsivov at codeweavers.com>
Signed-off-by: Andrew Eikum <aeikum at codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard at winehq.org>

---

 dlls/dsound/primary.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/dlls/dsound/primary.c b/dlls/dsound/primary.c
index b14bff7..830764a 100644
--- a/dlls/dsound/primary.c
+++ b/dlls/dsound/primary.c
@@ -387,8 +387,7 @@ err:
         IAudioStreamVolume_Release(volume);
     if (render)
         IAudioRenderClient_Release(render);
-    if (client)
-        IAudioClient_Release(client);
+    IAudioClient_Release(client);
     HeapFree(GetProcessHeap(), 0, wfx);
     return hres;
 }




More information about the wine-cvs mailing list