Jacek Caban : mshtml: Return success in IHTMLWindow2::moveBy and resizeBy.

Alexandre Julliard julliard at winehq.org
Tue Jun 21 11:13:48 CDT 2016


Module: wine
Branch: master
Commit: 03ed7f483dde46bf4720da02cd2e93e8d426f76f
URL:    http://source.winehq.org/git/wine.git/?a=commit;h=03ed7f483dde46bf4720da02cd2e93e8d426f76f

Author: Jacek Caban <jacek at codeweavers.com>
Date:   Tue Jun 21 15:12:34 2016 +0200

mshtml: Return success in IHTMLWindow2::moveBy and resizeBy.

Signed-off-by: Jacek Caban <jacek at codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard at winehq.org>

---

 dlls/mshtml/htmlwindow.c | 4 ++--
 dlls/mshtml/tests/dom.c  | 6 ++++++
 2 files changed, 8 insertions(+), 2 deletions(-)

diff --git a/dlls/mshtml/htmlwindow.c b/dlls/mshtml/htmlwindow.c
index e7f6144..d9f1346 100644
--- a/dlls/mshtml/htmlwindow.c
+++ b/dlls/mshtml/htmlwindow.c
@@ -1461,7 +1461,7 @@ static HRESULT WINAPI HTMLWindow2_moveBy(IHTMLWindow2 *iface, LONG x, LONG y)
 {
     HTMLWindow *This = impl_from_IHTMLWindow2(iface);
     FIXME("(%p)->(%d %d)\n", This, x, y);
-    return E_NOTIMPL;
+    return S_FALSE;
 }
 
 static HRESULT WINAPI HTMLWindow2_resizeTo(IHTMLWindow2 *iface, LONG x, LONG y)
@@ -1475,7 +1475,7 @@ static HRESULT WINAPI HTMLWindow2_resizeBy(IHTMLWindow2 *iface, LONG x, LONG y)
 {
     HTMLWindow *This = impl_from_IHTMLWindow2(iface);
     FIXME("(%p)->(%d %d)\n", This, x, y);
-    return E_NOTIMPL;
+    return S_FALSE;
 }
 
 static HRESULT WINAPI HTMLWindow2_get_external(IHTMLWindow2 *iface, IDispatch **p)
diff --git a/dlls/mshtml/tests/dom.c b/dlls/mshtml/tests/dom.c
index e5275e8..dce65d5 100644
--- a/dlls/mshtml/tests/dom.c
+++ b/dlls/mshtml/tests/dom.c
@@ -6646,6 +6646,12 @@ static void test_window(IHTMLDocument2 *doc)
     set_window_status(window, "Test!");
     test_history(window);
 
+    hres = IHTMLWindow2_moveBy(window, 0, 0);
+    ok(hres == S_FALSE, "moveBy failed: %08x\n", hres);
+
+    hres = IHTMLWindow2_resizeBy(window, 0, 0);
+    ok(hres == S_FALSE, "resizeBy failed: %08x\n", hres);
+
     hres = IHTMLWindow2_QueryInterface(window, &IID_IHTMLWindow5, (void**)&window5);
     if(SUCCEEDED(hres)) {
         ok(window5 != NULL, "window5 == NULL\n");




More information about the wine-cvs mailing list