Jacek Caban : mshtml: Always return false in IHTMLDOMAttribute2:: get_expando for detached attributes.

Alexandre Julliard julliard at wine.codeweavers.com
Tue Mar 1 10:44:07 CST 2016


Module: wine
Branch: master
Commit: 4e9324c43e639b50edfe614fbec0697c86f7b8f1
URL:    http://source.winehq.org/git/wine.git/?a=commit;h=4e9324c43e639b50edfe614fbec0697c86f7b8f1

Author: Jacek Caban <jacek at codeweavers.com>
Date:   Tue Mar  1 14:28:52 2016 +0100

mshtml: Always return false in IHTMLDOMAttribute2::get_expando for detached attributes.

Signed-off-by: Jacek Caban <jacek at codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard at winehq.org>

---

 dlls/mshtml/htmlattr.c  | 2 +-
 dlls/mshtml/tests/dom.c | 1 +
 2 files changed, 2 insertions(+), 1 deletion(-)

diff --git a/dlls/mshtml/htmlattr.c b/dlls/mshtml/htmlattr.c
index 446cb6f..885b2aa 100644
--- a/dlls/mshtml/htmlattr.c
+++ b/dlls/mshtml/htmlattr.c
@@ -335,7 +335,7 @@ static HRESULT WINAPI HTMLDOMAttribute2_get_expando(IHTMLDOMAttribute2 *iface, V
 
     TRACE("(%p)->(%p)\n", This, p);
 
-    *p = get_dispid_type(This->dispid) == DISPEXPROP_BUILTIN ? VARIANT_FALSE : VARIANT_TRUE;
+    *p = !This->elem || get_dispid_type(This->dispid) == DISPEXPROP_BUILTIN ? VARIANT_FALSE : VARIANT_TRUE;
     return S_OK;
 }
 
diff --git a/dlls/mshtml/tests/dom.c b/dlls/mshtml/tests/dom.c
index e27339a..11e9d27 100644
--- a/dlls/mshtml/tests/dom.c
+++ b/dlls/mshtml/tests/dom.c
@@ -8919,6 +8919,7 @@ static void test_create_elems(IHTMLDocument2 *doc)
             test_no_iface((IUnknown*)attr, &IID_IHTMLDOMNode);
 
             test_attr_node_name(attr, "Test");
+            test_attr_expando(attr, VARIANT_FALSE);
 
             IHTMLDOMAttribute_Release(attr);
         }




More information about the wine-cvs mailing list