Nikolay Sivov : notepad: Make sure to use large enough buffer when composing window title ( Coverity).

Alexandre Julliard julliard at wine.codeweavers.com
Tue Mar 8 08:03:02 CST 2016


Module: wine
Branch: master
Commit: ba5e12ae8332246d64d0f3b2827ff3d5e7b6c760
URL:    http://source.winehq.org/git/wine.git/?a=commit;h=ba5e12ae8332246d64d0f3b2827ff3d5e7b6c760

Author: Nikolay Sivov <nsivov at codeweavers.com>
Date:   Mon Mar  7 22:04:25 2016 +0300

notepad: Make sure to use large enough buffer when composing window title (Coverity).

Signed-off-by: Nikolay Sivov <nsivov at codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard at winehq.org>

---

 programs/notepad/dialog.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/programs/notepad/dialog.c b/programs/notepad/dialog.c
index 1ea2ef9..94301b8 100644
--- a/programs/notepad/dialog.c
+++ b/programs/notepad/dialog.c
@@ -101,9 +101,9 @@ VOID ShowLastError(void)
  */
 void UpdateWindowCaption(void)
 {
-  WCHAR szCaption[MAX_STRING_LEN];
-  WCHAR szNotepad[MAX_STRING_LEN];
   static const WCHAR hyphenW[] = { ' ','-',' ',0 };
+  WCHAR szNotepad[64];
+  WCHAR szCaption[ARRAY_SIZE(Globals.szFileTitle) + ARRAY_SIZE(hyphenW) + ARRAY_SIZE(szNotepad)];
 
   if (Globals.szFileTitle[0] != '\0')
       lstrcpyW(szCaption, Globals.szFileTitle);




More information about the wine-cvs mailing list