Nikolay Sivov : ieframe: Handle CreateView() failure in ActivateMe() ( Coverity).

Alexandre Julliard julliard at wine.codeweavers.com
Mon Mar 14 09:05:21 CDT 2016


Module: wine
Branch: master
Commit: 2dc49eee2297e69b9c0a802a2a288adc6a627066
URL:    http://source.winehq.org/git/wine.git/?a=commit;h=2dc49eee2297e69b9c0a802a2a288adc6a627066

Author: Nikolay Sivov <nsivov at codeweavers.com>
Date:   Tue Mar  8 16:07:46 2016 +0300

ieframe: Handle CreateView() failure in ActivateMe() (Coverity).

Signed-off-by: Nikolay Sivov <nsivov at codeweavers.com>
Signed-off-by: Jacek Caban <jacek at codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard at winehq.org>

---

 dlls/ieframe/client.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/dlls/ieframe/client.c b/dlls/ieframe/client.c
index dadbe13..d82195f 100644
--- a/dlls/ieframe/client.c
+++ b/dlls/ieframe/client.c
@@ -390,8 +390,10 @@ static HRESULT WINAPI OleDocumentSite_ActivateMe(IOleDocumentSite *iface,
     if(FAILED(hres))
         return hres;
 
-    IOleDocument_CreateView(oledoc, (IOleInPlaceSite*) &This->IOleInPlaceSiteEx_iface, NULL, 0, &This->view);
+    hres = IOleDocument_CreateView(oledoc, (IOleInPlaceSite*) &This->IOleInPlaceSiteEx_iface, NULL, 0, &This->view);
     IOleDocument_Release(oledoc);
+    if(FAILED(hres))
+        return hres;
 
     GetClientRect(This->hwnd, &rect);
     IOleDocumentView_SetRect(This->view, &rect);




More information about the wine-cvs mailing list