Francois Gouget : testbot/TestAgent: Clearly identify all the 'out of eval ' return calls.

Alexandre Julliard julliard at wine.codeweavers.com
Wed Mar 23 10:42:19 CDT 2016


Module: tools
Branch: master
Commit: 8a64b64f5a3ed581468096633c355b0eba4382f8
URL:    http://source.winehq.org/git/tools.git/?a=commit;h=8a64b64f5a3ed581468096633c355b0eba4382f8

Author: Francois Gouget <fgouget at free.fr>
Date:   Wed Mar 23 11:48:52 2016 +0100

testbot/TestAgent: Clearly identify all the 'out of eval' return calls.

Signed-off-by: Francois Gouget <fgouget at free.fr>
Signed-off-by: Alexandre Julliard <julliard at winehq.org>

---

 testbot/lib/WineTestBot/TestAgent.pm | 20 ++++++++++----------
 1 file changed, 10 insertions(+), 10 deletions(-)

diff --git a/testbot/lib/WineTestBot/TestAgent.pm b/testbot/lib/WineTestBot/TestAgent.pm
index a87b3f2..f255e0f 100644
--- a/testbot/lib/WineTestBot/TestAgent.pm
+++ b/testbot/lib/WineTestBot/TestAgent.pm
@@ -266,13 +266,13 @@ sub _RecvRawData($$$)
       {
         alarm(0);
         $self->_SetError($FATAL, "network read error ($self->{rpc}:$Name:$Received/$Size): $!");
-        return;
+        return; # out of eval
       }
       if ($r == 0)
       {
         alarm(0);
         $self->_SetError($FATAL, "network read got a premature EOF ($self->{rpc}:$Name:$Received/$Size)");
-        return;
+        return; # out of eval
       }
       $Data .= $Buffer;
       $Received += $r;
@@ -310,13 +310,13 @@ sub _SkipRawData($$)
       {
         alarm(0);
         $self->_SetError($FATAL, "network skip failed ($self->{rpc}:$Name:$Received/$Size): $!");
-        return;
+        return; # out of eval
       }
       if ($n == 0)
       {
         alarm(0);
         $self->_SetError($FATAL, "network skip got a premature EOF ($self->{rpc}:$Name:$Received/$Size)");
-        return;
+        return; # out of eval
       }
       $Received += $n;
       $Remaining -= $n;
@@ -481,13 +481,13 @@ sub _RecvFile($$$$)
       {
         alarm(0);
         $self->_SetError($FATAL, "got a network error while receiving '$Filename' ($self->{rpc}:$Name:$Received/$Size): $!");
-        return;
+        return; # out of eval
       }
       if ($r == 0)
       {
         alarm(0);
         $self->_SetError($FATAL, "got a premature EOF while receiving '$Filename' ($self->{rpc}:$Name:$Received/$Size)");
-        return;
+        return; # out of eval
       }
       $Remaining -= $r;
       my $w = syswrite($Dst, $Buffer, $r, 0);
@@ -497,7 +497,7 @@ sub _RecvFile($$$$)
         alarm(0);
         $self->_SetError($ERROR, "an error occurred while writing to '$Filename' ($self->{rpc}:$Name:$Received/$Size): $!");
         $self->_SkipRawData($Name, $Remaining);
-        return;
+        return; # out of eval
       }
     }
     alarm(0);
@@ -795,13 +795,13 @@ sub _SendFile($$$$)
       {
         alarm(0);
         $self->_SetError($FATAL, "an error occurred while reading from '$Filename' ($self->{rpc}:$Name:$Sent/$Size): $!");
-        return;
+        return; # out of eval
       }
       if ($r == 0)
       {
         alarm(0);
         $self->_SetError($FATAL, "got a premature EOF while reading from '$Filename' ($self->{rpc}:$Name:$Sent/$Size)");
-        return;
+        return; # out of eval
       }
       $Remaining -= $r;
       my $w = $self->_Write($Name, $Buffer);
@@ -810,7 +810,7 @@ sub _SendFile($$$$)
       {
         alarm(0);
         $self->_SetError($FATAL, "got a network error while sending '$Filename' ($self->{rpc}:$Name:$Sent+$s/$Size): $!");
-        return;
+        return; # out of eval
       }
     }
     alarm(0);




More information about the wine-cvs mailing list