Alex Henrie : riched20: Don' t call UpdateWindow after setting the background color.
Alexandre Julliard
julliard at wine.codeweavers.com
Sat May 14 10:07:27 CDT 2016
Module: wine
Branch: master
Commit: e60b2766987c09dd3ea13adc57df11ee03c05f2a
URL: http://source.winehq.org/git/wine.git/?a=commit;h=e60b2766987c09dd3ea13adc57df11ee03c05f2a
Author: Alex Henrie <alexhenrie24 at gmail.com>
Date: Mon May 9 08:57:12 2016 -0600
riched20: Don't call UpdateWindow after setting the background color.
Signed-off-by: Alex Henrie <alexhenrie24 at gmail.com>
Signed-off-by: Huw Davies <huw at codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard at winehq.org>
---
dlls/riched20/editor.c | 1 -
dlls/riched20/tests/editor.c | 12 ++++++++++++
2 files changed, 12 insertions(+), 1 deletion(-)
diff --git a/dlls/riched20/editor.c b/dlls/riched20/editor.c
index 7ac94ca..85395e7 100644
--- a/dlls/riched20/editor.c
+++ b/dlls/riched20/editor.c
@@ -3626,7 +3626,6 @@ LRESULT ME_HandleMessage(ME_TextEditor *editor, UINT msg, WPARAM wParam,
editor->hbrBackground = CreateSolidBrush(editor->rgbBackColor);
}
ITextHost_TxInvalidateRect(editor->texthost, NULL, TRUE);
- ITextHost_TxViewChange(editor->texthost, TRUE);
return lColor;
}
case EM_GETMODIFY:
diff --git a/dlls/riched20/tests/editor.c b/dlls/riched20/tests/editor.c
index 6a77d9a..31d5128 100644
--- a/dlls/riched20/tests/editor.c
+++ b/dlls/riched20/tests/editor.c
@@ -8337,6 +8337,17 @@ static void test_rtf_specials(void)
DestroyWindow( edit );
}
+static void test_background(void)
+{
+ HWND hwndRichEdit = new_richedit(NULL);
+
+ /* set the background color to black */
+ ValidateRect(hwndRichEdit, NULL);
+ SendMessageA(hwndRichEdit, EM_SETBKGNDCOLOR, FALSE, RGB(0, 0, 0));
+ ok(GetUpdateRect(hwndRichEdit, NULL, FALSE), "Update rectangle is empty!\n");
+
+ DestroyWindow(hwndRichEdit);
+}
START_TEST( editor )
{
@@ -8408,6 +8419,7 @@ START_TEST( editor )
test_EM_SETFONTSIZE();
test_alignment_style();
test_rtf_specials();
+ test_background();
/* Set the environment variable WINETEST_RICHED20 to keep windows
* responsive and open for 30 seconds. This is useful for debugging.
More information about the wine-cvs
mailing list