Kirill Smirnov : winhlp32: Do not pass NULL to strchr() (spotted by clang) .

Alexandre Julliard julliard at wine.codeweavers.com
Tue May 17 11:19:38 CDT 2016


Module: wine
Branch: master
Commit: 5a3ad0ecf08c00fc0b7b2f24e55be27b7c3f5da0
URL:    http://source.winehq.org/git/wine.git/?a=commit;h=5a3ad0ecf08c00fc0b7b2f24e55be27b7c3f5da0

Author: Kirill Smirnov <kirill.k.smirnov at gmail.com>
Date:   Mon May  9 18:56:14 2016 +0300

winhlp32: Do not pass NULL to strchr() (spotted by clang).

Signed-off-by: Kirill K. Smirnov <kirill.k.smirnov at gmail.com>
Signed-off-by: Alexandre Julliard <julliard at winehq.org>

---

 programs/winhlp32/macro.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/programs/winhlp32/macro.c b/programs/winhlp32/macro.c
index f0a6893..5a25d6c 100644
--- a/programs/winhlp32/macro.c
+++ b/programs/winhlp32/macro.c
@@ -607,7 +607,7 @@ static void CALLBACK MACRO_JumpID(LPCSTR lpszPathWindow, LPCSTR topic_id)
     LPSTR       ptr;
 
     WINE_TRACE("(%s, %s)\n", debugstr_a(lpszPathWindow), debugstr_a(topic_id));
-    if ((ptr = strchr(lpszPathWindow, '>')) != NULL)
+    if (lpszPathWindow && (ptr = strchr(lpszPathWindow, '>')) != NULL)
     {
         LPSTR   tmp;
         size_t  sz;




More information about the wine-cvs mailing list