Jacek Caban : wininet: Added missing LeaveCriticalSection to set_cookie ( coverity).

Alexandre Julliard julliard at winehq.org
Mon May 30 09:43:41 CDT 2016


Module: wine
Branch: master
Commit: 0fdba71bed309920b9932da4faf6c169c0ce318a
URL:    http://source.winehq.org/git/wine.git/?a=commit;h=0fdba71bed309920b9932da4faf6c169c0ce318a

Author: Jacek Caban <jacek at codeweavers.com>
Date:   Sun May 29 19:19:26 2016 +0200

wininet: Added missing LeaveCriticalSection to set_cookie (coverity).

Signed-off-by: Jacek Caban <jacek at codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard at winehq.org>

---

 dlls/wininet/cookie.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/dlls/wininet/cookie.c b/dlls/wininet/cookie.c
index 34c6c0b..5de2304 100644
--- a/dlls/wininet/cookie.c
+++ b/dlls/wininet/cookie.c
@@ -1003,6 +1003,7 @@ DWORD set_cookie(substr_t domain, substr_t path, substr_t name, substr_t data, D
         if ((thisCookie->flags & INTERNET_COOKIE_HTTPONLY) && !(flags & INTERNET_COOKIE_HTTPONLY)) {
             WARN("An attempt to override httponly cookie\n");
             SetLastError(ERROR_INVALID_OPERATION);
+            LeaveCriticalSection(&cookie_cs);
             return COOKIE_STATE_REJECT;
         }
 




More information about the wine-cvs mailing list