Nikolay Sivov : mshtml: Fix some IUri leaks (Valgrind).

Alexandre Julliard julliard at winehq.org
Mon Nov 14 17:07:08 CST 2016


Module: wine
Branch: master
Commit: 892d2e8c29e3d1dad0ee11491eef9ddd9d826351
URL:    http://source.winehq.org/git/wine.git/?a=commit;h=892d2e8c29e3d1dad0ee11491eef9ddd9d826351

Author: Nikolay Sivov <nsivov at codeweavers.com>
Date:   Thu Nov 10 10:44:37 2016 +0300

mshtml: Fix some IUri leaks (Valgrind).

Signed-off-by: Nikolay Sivov <nsivov at codeweavers.com>
Signed-off-by: Jacek Caban <jacek at codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard at winehq.org>

---

 dlls/mshtml/script.c | 6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)

diff --git a/dlls/mshtml/script.c b/dlls/mshtml/script.c
index f10a702..cb8f54a 100644
--- a/dlls/mshtml/script.c
+++ b/dlls/mshtml/script.c
@@ -1056,12 +1056,15 @@ HRESULT load_script(HTMLScriptElement *script_elem, const WCHAR *src, BOOL async
         return hres;
 
     hres = CreateURLMonikerEx2(NULL, uri, &mon, URL_MK_UNIFORM);
-    if(FAILED(hres))
+    if(FAILED(hres)) {
+        IUri_Release(uri);
         return hres;
+    }
 
     bsc = heap_alloc_zero(sizeof(*bsc));
     if(!bsc) {
         IMoniker_Release(mon);
+        IUri_Release(uri);
         return E_OUTOFMEMORY;
     }
 
@@ -1069,6 +1072,7 @@ HRESULT load_script(HTMLScriptElement *script_elem, const WCHAR *src, BOOL async
     IMoniker_Release(mon);
 
     hres = IUri_GetScheme(uri, &bsc->scheme);
+    IUri_Release(uri);
     if(FAILED(hres))
         bsc->scheme = URL_SCHEME_UNKNOWN;
 




More information about the wine-cvs mailing list