Nikolay Sivov : ieframe: Fix moniker leak on error path.
Alexandre Julliard
julliard at winehq.org
Mon Nov 14 17:07:08 CST 2016
Module: wine
Branch: master
Commit: 477e7fdfc0f7ccff9fbe9c3c69a37899e006f51d
URL: http://source.winehq.org/git/wine.git/?a=commit;h=477e7fdfc0f7ccff9fbe9c3c69a37899e006f51d
Author: Nikolay Sivov <nsivov at codeweavers.com>
Date: Thu Nov 10 14:47:10 2016 +0300
ieframe: Fix moniker leak on error path.
Signed-off-by: Nikolay Sivov <nsivov at codeweavers.com>
Signed-off-by: Jacek Caban <jacek at codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard at winehq.org>
---
dlls/ieframe/navigate.c | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/dlls/ieframe/navigate.c b/dlls/ieframe/navigate.c
index 296ed19..658857f 100644
--- a/dlls/ieframe/navigate.c
+++ b/dlls/ieframe/navigate.c
@@ -703,13 +703,16 @@ static HRESULT bind_to_object(DocHost *This, IMoniker *mon, LPCWSTR url, IBindCt
hres = IMoniker_GetDisplayName(mon, 0, NULL, &display_name);
if(FAILED(hres)) {
FIXME("GetDisplayName failed: %08x\n", hres);
+ IMoniker_Release(mon);
return hres;
}
hres = set_dochost_url(This, display_name);
CoTaskMemFree(display_name);
- if(FAILED(hres))
+ if(FAILED(hres)) {
+ IMoniker_Release(mon);
return hres;
+ }
IBindCtx_RegisterObjectParam(bindctx, (LPOLESTR)SZ_HTML_CLIENTSITE_OBJECTPARAM,
(IUnknown*)&This->IOleClientSite_iface);
More information about the wine-cvs
mailing list