Jeremy Newman : remove onlcick from show comment link, new handler in utils.js

[Jeremy Newman]

Module: appdb
Branch: master
Commit: dd264836426ded4434bb8969eb49f2765ebad586
URL:    http://source.winehq.org/git/appdb.git/?a=commit;h=dd264836426ded4434bb8969eb49f2765ebad586

Author: Jeremy Newman <jnewman at codeweavers.com>
Date:   Tue Nov 15 12:11:54 2016 -0600

remove onlcick from show comment link, new handler in utils.js

---

 include/comment.php | 14 ++++----------
 1 file changed, 4 insertions(+), 10 deletions(-)

diff --git a/include/comment.php b/include/comment.php
index 21c6a14..8334e37 100644
--- a/include/comment.php
+++ b/include/comment.php
@@ -503,16 +503,10 @@ class Comment {
     {
         $sLink = "commentview.php?iAppId={$oRow->appId}&iVersionId=".
             "{$oRow->versionId}&iThreadId={$oRow->parentId}";
-
-        $sOnClick = "showComment('{$oRow->commentId}');";
-
-        /**
-         * The return false line in the onClick is used to handle javascript 
-         * being disabled so we can fail gracefully to the old style.
-         */
-        return "<li><a href=\"$sLink\" onclick=\"$sOnClick return false;\">$oRow->subject</a>". 
-            ' by '.forum_lookup_user($oRow->userId)." on 
-             {$oRow->time}<div id=\"{$oRow->commentId}\"></div></li>\n";
+        return "<li><a href=\"$sLink\" class=\"showComment\" ".
+               "data-id=\"{$oRow->commentId}\">$oRow->subject</a>". 
+               ' by '.forum_lookup_user($oRow->userId)." on {$oRow->time}".
+               "<div id=\"comment-{$oRow->commentId}\"></div></li>\n";
     }
 
     /**