=?UTF-8?Q?Andr=C3=A9=20Hentschel=20?=: msvcrt: Don' t continue on demangle failure (Coverity).

Alexandre Julliard julliard at winehq.org
Fri Oct 7 15:09:15 CDT 2016


Module: wine
Branch: stable
Commit: 74711f31db91e42ec451056da8bb88394f2749f4
URL:    http://source.winehq.org/git/wine.git/?a=commit;h=74711f31db91e42ec451056da8bb88394f2749f4

Author: André Hentschel <nerv at dawncrow.de>
Date:   Tue Dec 22 19:35:04 2015 +0100

msvcrt: Don't continue on demangle failure (Coverity).

Signed-off-by: André Hentschel <nerv at dawncrow.de>
Signed-off-by: Piotr Caban <piotr at codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard at winehq.org>
(cherry picked from commit 51098fcd94457b46945a03131c4cd1f049682d17)
Signed-off-by: Michael Stefaniuc <mstefani at winehq.org>

---

 dlls/msvcrt/undname.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/dlls/msvcrt/undname.c b/dlls/msvcrt/undname.c
index ec2c2dd..5972320 100644
--- a/dlls/msvcrt/undname.c
+++ b/dlls/msvcrt/undname.c
@@ -1380,6 +1380,8 @@ static BOOL symbol_demangle(struct parsed_symbol* sym)
                         sym->current++;
                         str_array_init(&pmt);
                         demangle_datatype(sym, &ct, &pmt, FALSE);
+                        if (!demangle_datatype(sym, &ct, NULL, FALSE))
+                            goto done;
                         function_name = str_printf(sym, "%s%s `RTTI Type Descriptor'",
                                                    ct.left, ct.right);
                         sym->current--;




More information about the wine-cvs mailing list