Jeremy Newman : Revert "Fix submitTime field"
Jeremy Newman
jnewman at winehq.org
Mon Aug 28 13:37:51 CDT 2017
Module: appdb
Branch: master
Commit: 69991e4b2e9a211a043c3650249ba2017e77ac5e
URL: http://source.winehq.org/git/appdb.git/?a=commit;h=69991e4b2e9a211a043c3650249ba2017e77ac5e
Author: Jeremy Newman <jnewman at codeweavers.com>
Date: Mon Aug 28 13:36:26 2017 -0500
Revert "Fix submitTime field"
This reverts commit c2d2c7ad817828cafcf6e967b451fbdf009f268d.
---
include/testData.php | 7 ++++---
tables/alter.sql | 4 ----
tables/testResults.sql | 2 +-
3 files changed, 5 insertions(+), 8 deletions(-)
diff --git a/include/testData.php b/include/testData.php
index 98f1c09..49cfa69 100644
--- a/include/testData.php
+++ b/include/testData.php
@@ -84,11 +84,11 @@ class testData{
"testedRelease, staging, installs, runs,".
"usedWorkaround, workarounds,".
"testedRating, comments,".
- "submitterId, state,".
+ "submitTime, submitterId, state,".
"gpuMfr, graphicsDriver)".
"VALUES('?', '?', '?', '?', '?', '?', '?',".
"'?', '?', '?', '?', '?',".
- "'?', '?', '?', '?', '?', '?')",
+ "'?', '?', '?', '?', '?', '?', '?')",
$this->iVersionId,
$this->shWhatWorks,
$this->shWhatDoesnt,
@@ -102,7 +102,8 @@ class testData{
$this->sUsedWorkaround,
$this->shWorkarounds,
$this->sTestedRating,
- $this->sComments,
+ $this->sComments,
+ "NOW()",
$_SESSION['current']->iUserId,
$this->sState,
$this->sGpuMfr,
diff --git a/tables/alter.sql b/tables/alter.sql
index 8aa4423..457f8d9 100644
--- a/tables/alter.sql
+++ b/tables/alter.sql
@@ -1,6 +1,2 @@
/* append to this file when changes are required to the live db */
/* it will be cleared when the changes go live */
-ALTER TABLE `testResults` CHANGE `submitTime` `submitTime` DATETIME NOT NULL DEFAULT CURRENT_TIMESTAMP;
-
-/* to fix the incorrect entries*/
-UPDATE testResults SET submitTime = testedDate WHERE submitTime = '0000-00-00 00:00:00'
diff --git a/tables/testResults.sql b/tables/testResults.sql
index be80b9d..511c115 100644
--- a/tables/testResults.sql
+++ b/tables/testResults.sql
@@ -21,7 +21,7 @@ create table testResults (
workarounds text default NULL,
testedRating enum('Platinum','Gold','Silver','Bronze','Garbage') NOT NULL,
comments text,
- submitTime datetime NOT NULL default CURRENT_TIMESTAMP,
+ submitTime datetime NOT NULL,
submitterId int(11) NOT NULL default '0',
state enum('accepted','queued','rejected','pending','deleted') NOT NULL default 'accepted',
gpuMfr enum('AMD', 'Intel', 'Nvidia', 'Other', 'Unknown') default NULL,
More information about the wine-cvs
mailing list