Alex Henrie : appwiz.cpl: Add comment explaining why we use HTTP instead of HTTPS.

Alexandre Julliard julliard at winehq.org
Wed Dec 13 15:40:22 CST 2017


Module: wine
Branch: master
Commit: 70366fcd9001ba05a058de193e750bb977c32cc1
URL:    http://source.winehq.org/git/wine.git/?a=commit;h=70366fcd9001ba05a058de193e750bb977c32cc1

Author: Alex Henrie <alexhenrie24 at gmail.com>
Date:   Tue Dec 12 19:55:37 2017 -0700

appwiz.cpl: Add comment explaining why we use HTTP instead of HTTPS.

Signed-off-by: Alex Henrie <alexhenrie24 at gmail.com>
Signed-off-by: Alexandre Julliard <julliard at winehq.org>

---

 dlls/appwiz.cpl/addons.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/dlls/appwiz.cpl/addons.c b/dlls/appwiz.cpl/addons.c
index 5ec49cf..76f00a0 100644
--- a/dlls/appwiz.cpl/addons.c
+++ b/dlls/appwiz.cpl/addons.c
@@ -80,6 +80,9 @@ typedef struct {
     LPCWSTR dialog_template;
 } addon_info_t;
 
+/* Download addon files over HTTP because Wine depends on an external library
+ * for TLS, so we can't be sure that HTTPS will work. The integrity of each file
+ * is checked with a hardcoded cryptographically secure hash. */
 static const addon_info_t addons_info[] = {
     {
         GECKO_VERSION,




More information about the wine-cvs mailing list