Alex Henrie : mmdevapi/tests: Fix memory leaks (Coverity).
Alexandre Julliard
julliard at winehq.org
Wed Dec 20 14:09:21 CST 2017
Module: wine
Branch: master
Commit: 10aa228cccc24aa392e02de8f2b496fe31558d0d
URL: http://source.winehq.org/git/wine.git/?a=commit;h=10aa228cccc24aa392e02de8f2b496fe31558d0d
Author: Alex Henrie <alexhenrie24 at gmail.com>
Date: Tue Dec 19 09:00:17 2017 -0700
mmdevapi/tests: Fix memory leaks (Coverity).
Signed-off-by: Alex Henrie <alexhenrie24 at gmail.com>
Signed-off-by: Andrew Eikum <aeikum at codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard at winehq.org>
---
dlls/mmdevapi/tests/capture.c | 4 ++--
dlls/mmdevapi/tests/render.c | 8 ++------
2 files changed, 4 insertions(+), 8 deletions(-)
diff --git a/dlls/mmdevapi/tests/capture.c b/dlls/mmdevapi/tests/capture.c
index 99da296..3cdfda1 100644
--- a/dlls/mmdevapi/tests/capture.c
+++ b/dlls/mmdevapi/tests/capture.c
@@ -556,8 +556,7 @@ static void test_audioclient(void)
if (hr != S_OK)
{
skip("Cannot initialize %08x, remainder of tests is useless\n", hr);
- CoTaskMemFree(pwfx);
- return;
+ goto cleanup;
}
hr = IAudioClient_GetStreamLatency(ac, NULL);
@@ -592,6 +591,7 @@ static void test_audioclient(void)
test_capture(ac, handle, pwfx);
+cleanup:
IAudioClient_Release(ac);
CloseHandle(handle);
CoTaskMemFree(pwfx);
diff --git a/dlls/mmdevapi/tests/render.c b/dlls/mmdevapi/tests/render.c
index e394d59..9d3e861 100644
--- a/dlls/mmdevapi/tests/render.c
+++ b/dlls/mmdevapi/tests/render.c
@@ -323,11 +323,7 @@ static void test_audioclient(void)
hr = IAudioClient_Initialize(ac, AUDCLNT_SHAREMODE_SHARED, 0, 5000000, 0, pwfx, NULL);
ok(hr == S_OK, "Valid Initialize returns %08x\n", hr);
if (hr != S_OK)
- {
- IAudioClient_Release(ac);
- CoTaskMemFree(pwfx);
- return;
- }
+ goto cleanup;
hr = IAudioClient_GetStreamLatency(ac, NULL);
ok(hr == E_POINTER, "GetStreamLatency(NULL) call returns %08x\n", hr);
@@ -372,8 +368,8 @@ static void test_audioclient(void)
hr = IAudioClient_Start(ac);
ok(hr == AUDCLNT_E_NOT_STOPPED, "Start twice returns %08x\n", hr);
+cleanup:
IAudioClient_Release(ac);
-
CloseHandle(handle);
CoTaskMemFree(pwfx);
}
More information about the wine-cvs
mailing list