Akihiro Sagawa : version: Ignore flag values in Ex functions.
Alexandre Julliard
julliard at winehq.org
Mon Feb 13 15:24:41 CST 2017
Module: wine
Branch: master
Commit: 8e1335b3a320d0ba9b6d9656eb2f4377124b96f5
URL: http://source.winehq.org/git/wine.git/?a=commit;h=8e1335b3a320d0ba9b6d9656eb2f4377124b96f5
Author: Akihiro Sagawa <sagawa.aki at gmail.com>
Date: Mon Feb 13 23:46:07 2017 +0900
version: Ignore flag values in Ex functions.
Signed-off-by: Akihiro Sagawa <sagawa.aki at gmail.com>
Signed-off-by: Alexandre Julliard <julliard at winehq.org>
---
dlls/version/version.c | 32 +++++++++++---------------------
1 file changed, 11 insertions(+), 21 deletions(-)
diff --git a/dlls/version/version.c b/dlls/version/version.c
index 43f5c18..9c6869d 100644
--- a/dlls/version/version.c
+++ b/dlls/version/version.c
@@ -628,14 +628,7 @@ DWORD WINAPI GetFileVersionInfoSizeExW( DWORD flags, LPCWSTR filename, LPDWORD h
HMODULE hModule;
OFSTRUCT ofs;
- if (flags)
- {
- FIXME("stub: %x %s %p\n", flags, wine_dbgstr_w(filename), handle);
- SetLastError(ERROR_CALL_NOT_IMPLEMENTED);
- return 0;
- }
-
- TRACE("(%s,%p)\n", debugstr_w(filename), handle );
+ TRACE("(0x%x,%s,%p)\n", flags, debugstr_w(filename), handle );
if (handle) *handle = 0;
@@ -649,6 +642,8 @@ DWORD WINAPI GetFileVersionInfoSizeExW( DWORD flags, LPCWSTR filename, LPDWORD h
SetLastError(ERROR_BAD_PATHNAME);
return 0;
}
+ if (flags)
+ FIXME("flags 0x%x ignored\n", flags);
if ((lzfd = LZOpenFileW( (LPWSTR)filename, &ofs, OF_READ )) != HFILE_ERROR)
{
@@ -707,14 +702,14 @@ DWORD WINAPI GetFileVersionInfoSizeExA( DWORD flags, LPCSTR filename, LPDWORD ha
UNICODE_STRING filenameW;
DWORD retval;
- TRACE("(%s,%p)\n", debugstr_a(filename), handle );
+ TRACE("(0x%x,%s,%p)\n", flags, debugstr_a(filename), handle );
if(filename)
RtlCreateUnicodeStringFromAsciiz(&filenameW, filename);
else
filenameW.Buffer = NULL;
- retval = GetFileVersionInfoSizeExW(0, filenameW.Buffer, handle);
+ retval = GetFileVersionInfoSizeExW(flags, filenameW.Buffer, handle);
RtlFreeUnicodeString(&filenameW);
@@ -733,21 +728,16 @@ BOOL WINAPI GetFileVersionInfoExW( DWORD flags, LPCWSTR filename, DWORD handle,
HMODULE hModule;
VS_VERSION_INFO_STRUCT32* vvis = data;
- if (flags)
- {
- FIXME("stub: %x %s %u %u %p\n", flags, wine_dbgstr_w(filename), handle, datasize, data);
- SetLastError(ERROR_CALL_NOT_IMPLEMENTED);
- return 0;
- }
-
- TRACE("(%s,%d,size=%d,data=%p)\n",
- debugstr_w(filename), handle, datasize, data );
+ TRACE("(0x%x,%s,%d,size=%d,data=%p)\n",
+ flags, debugstr_w(filename), handle, datasize, data );
if (!data)
{
SetLastError(ERROR_INVALID_DATA);
return FALSE;
}
+ if (flags)
+ FIXME("flags 0x%x ignored\n", flags);
if ((lzfd = LZOpenFileW( (LPWSTR)filename, &ofs, OF_READ )) != HFILE_ERROR)
{
@@ -810,8 +800,8 @@ BOOL WINAPI GetFileVersionInfoExA( DWORD flags, LPCSTR filename, DWORD handle, D
UNICODE_STRING filenameW;
BOOL retval;
- TRACE("(%s,%d,size=%d,data=%p)\n",
- debugstr_a(filename), handle, datasize, data );
+ TRACE("(0x%x,%s,%d,size=%d,data=%p)\n",
+ flags, debugstr_a(filename), handle, datasize, data );
if(filename)
RtlCreateUnicodeStringFromAsciiz(&filenameW, filename);
More information about the wine-cvs
mailing list