Gerald Pfeifer : propsys: Use snprintf in PROPVAR_ConvertFILETIME.

Alexandre Julliard julliard at winehq.org
Mon Feb 20 15:03:44 CST 2017


Module: wine
Branch: master
Commit: 6df21d4015dcc4564e223062ec41252700fc6590
URL:    http://source.winehq.org/git/wine.git/?a=commit;h=6df21d4015dcc4564e223062ec41252700fc6590

Author: Gerald Pfeifer <gerald at pfeifer.com>
Date:   Sat Feb 11 23:13:00 2017 +0100

propsys: Use snprintf in PROPVAR_ConvertFILETIME.

Signed-off-by: Gerald Pfeifer <gerald at pfeifer.com>
Signed-off-by: Alexandre Julliard <julliard at winehq.org>

---

 dlls/propsys/propvar.c | 10 ++++++----
 1 file changed, 6 insertions(+), 4 deletions(-)

diff --git a/dlls/propsys/propvar.c b/dlls/propsys/propvar.c
index 002555e..3fee67a 100644
--- a/dlls/propsys/propvar.c
+++ b/dlls/propsys/propvar.c
@@ -50,13 +50,15 @@ static HRESULT PROPVAR_ConvertFILETIME(PROPVARIANT *ppropvarDest,
             static const char format[] = "%04d/%02d/%02d:%02d:%02d:%02d.%03d";
 
             ppropvarDest->u.pszVal = HeapAlloc(GetProcessHeap(), 0,
-                                             lstrlenA(format) + 1);
+                                             sizeof(format));
             if (!ppropvarDest->u.pszVal)
                 return E_OUTOFMEMORY;
 
-            sprintf(ppropvarDest->u.pszVal, format, time.wYear, time.wMonth,
-                    time.wDay, time.wHour, time.wMinute,
-                    time.wSecond, time.wMilliseconds);
+            snprintf( ppropvarDest->u.pszVal, sizeof(format),
+                      format,
+                      time.wYear, time.wMonth, time.wDay,
+                      time.wHour, time.wMinute, time.wSecond,
+                      time.wMilliseconds );
 
             return S_OK;
         }




More information about the wine-cvs mailing list