Nikolay Sivov : comctl32/toolbar: Protect from NULL pointer access in TB_GETBUTTONINFOW handler.
Alexandre Julliard
julliard at winehq.org
Tue Feb 28 03:45:55 CST 2017
Module: wine
Branch: oldstable
Commit: fa792eb157262dea71e8bc674f12946b701fedba
URL: http://source.winehq.org/git/wine.git/?a=commit;h=fa792eb157262dea71e8bc674f12946b701fedba
Author: Nikolay Sivov <nsivov at codeweavers.com>
Date: Wed Jan 11 15:31:42 2017 +0300
comctl32/toolbar: Protect from NULL pointer access in TB_GETBUTTONINFOW handler.
Signed-off-by: Nikolay Sivov <nsivov at codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard at winehq.org>
(cherry picked from commit 26067cc0b9e39ac80bd13f8c90d9c9948eb60fbb)
Signed-off-by: Michael Stefaniuc <mstefani at winehq.org>
---
dlls/comctl32/tests/toolbar.c | 11 ++++++++++-
dlls/comctl32/toolbar.c | 2 +-
2 files changed, 11 insertions(+), 2 deletions(-)
diff --git a/dlls/comctl32/tests/toolbar.c b/dlls/comctl32/tests/toolbar.c
index bab746b..43cdcc9 100644
--- a/dlls/comctl32/tests/toolbar.c
+++ b/dlls/comctl32/tests/toolbar.c
@@ -1713,12 +1713,13 @@ static void test_recalc(void)
static void test_getbuttoninfo(void)
{
HWND hToolbar = NULL;
+ TBBUTTONINFOW tbiW;
+ TBBUTTONINFOA tbi;
int i;
rebuild_toolbar_with_buttons(&hToolbar);
for (i = 0; i < 128; i++)
{
- TBBUTTONINFOA tbi;
int ret;
tbi.cbSize = i;
@@ -1730,6 +1731,14 @@ static void test_getbuttoninfo(void)
compare(ret, -1, "%d");
}
}
+
+ /* TBIF_TEXT with NULL pszText */
+ memset(&tbiW, 0, sizeof(tbiW));
+ tbiW.cbSize = sizeof(tbiW);
+ tbiW.dwMask = TBIF_BYINDEX | TBIF_STYLE | TBIF_COMMAND | TBIF_TEXT;
+ i = SendMessageA(hToolbar, TB_GETBUTTONINFOW, 1, (LPARAM)&tbiW);
+ ok(i == 1, "Got index %d\n", i);
+
DestroyWindow(hToolbar);
}
diff --git a/dlls/comctl32/toolbar.c b/dlls/comctl32/toolbar.c
index ae6f21e..4e4c940 100644
--- a/dlls/comctl32/toolbar.c
+++ b/dlls/comctl32/toolbar.c
@@ -3400,7 +3400,7 @@ TOOLBAR_GetButtonInfoT(const TOOLBAR_INFO *infoPtr, INT Id, LPTBBUTTONINFOW lpTb
Str_GetPtrW(lpText, lpTbInfo->pszText, lpTbInfo->cchText);
else
Str_GetPtrWtoA(lpText, (LPSTR)lpTbInfo->pszText, lpTbInfo->cchText);
- } else
+ } else if (!bUnicode || lpTbInfo->pszText)
lpTbInfo->pszText[0] = '\0';
}
return nIndex;
More information about the wine-cvs
mailing list