Rosanne DiMesio : Move operating system selection list to bottom of form
Jeremy Newman
jnewman at winehq.org
Tue Jul 25 09:14:37 CDT 2017
Module: appdb
Branch: master
Commit: 4ca65e1b936c3455821601d0e6b79af164190598
URL: http://source.winehq.org/git/appdb.git/?a=commit;h=4ca65e1b936c3455821601d0e6b79af164190598
Author: Rosanne DiMesio <dimesio at earthlink.net>
Date: Tue Jul 25 08:09:20 2017 -0500
Move operating system selection list to bottom of form
Placing it just above the field for entering new operating
systems makes the relationship between the two clearer.
Signed-off-by: Rosanne DiMesio <dimesio at earthlink.net>
Signed-off-by: Jeremy Newman <jnewman at codeweavers.com>
---
include/testData.php | 44 ++++++++++++++++++++++----------------------
1 file changed, 22 insertions(+), 22 deletions(-)
diff --git a/include/testData.php b/include/testData.php
index 8af655c..d1af688 100644
--- a/include/testData.php
+++ b/include/testData.php
@@ -808,28 +808,6 @@ class testData{
echo '<td class="color0"><input type=text name="sTestedDate" value="'.$this->sTestedDate.'" size="20"></td></tr>',"\n";
echo '<tr valign=top><td class="color1"></td><td class="color0"><p/>YYYY-MM-DD HH:MM:SS</td></tr>',"\n";
- // Distribution
- $oDistribution = new distribution($this->iDistributionId);
- $sDistributionHelp = "";
- if(!$this->iDistributionId || $oDistribution->objectGetState() != 'accepted')
- {
- if(!$this->iDistributionId)
- {
- $sDistributionHelp = "If yours is not on the list, ".
- "please add it using the form below.<br>";
- } else
- {
- $sDistributionHelp = '<p class="bg-danger"><span class = "text-danger fa fa-exclamation-triangle" style="font-size:125%"></span> The user submitted a new operating system; please review it in the form below.</p>';
- }
- }
-
- echo '<tr valign=top><td class="color0"><b>Operating system</b></td class="color0">',"\n";
-
- echo '<td class=color0>',"\n";
- echo $sDistributionHelp;
- distribution::make_distribution_list("iTestDistributionId", $this->iDistributionId);
- echo '</td></tr>',"\n";
-
// Version List
echo '<tr><td class=color1><b>Tested release</b></td><td class=color0>',"\n";
echo make_bugzilla_version_list("sTestedRelease", $this->sTestedRelease);
@@ -866,6 +844,28 @@ class testData{
echo '<input type="hidden" name="iTestingId" value="'.$this->iTestingId.'" >';
echo '<input type="hidden" name="iTestDataId" value="'.$this->iTestingId.'" >';
+ // Distribution
+ $oDistribution = new distribution($this->iDistributionId);
+ $sDistributionHelp = "";
+ if(!$this->iDistributionId || $oDistribution->objectGetState() != 'accepted')
+ {
+ if(!$this->iDistributionId)
+ {
+ $sDistributionHelp = "If yours is not on the list, ".
+ "please add it using the form below.<br>";
+ } else
+ {
+ $sDistributionHelp = '<p class="bg-danger"><span class = "text-danger fa fa-exclamation-triangle" style="font-size:125%"></span> The user submitted a new operating system; please review it in the form below.</p>';
+ }
+ }
+
+ echo '<tr valign=top><td class="color0"><b>Operating system</b></td class="color0">',"\n";
+
+ echo '<td class=color0>',"\n";
+ echo $sDistributionHelp;
+ distribution::make_distribution_list("iTestDistributionId", $this->iDistributionId);
+ echo '</td></tr>',"\n";
+
// Display confirmation box for changing the Wine version
$oOldTest = new testData($this->iTestingId);
if($this->iTestingId && $oOldTest->sTestedRelease != $this->sTestedRelease
More information about the wine-cvs
mailing list