Matteo Bruni : d3dx9/tests: Add a comment about the negation in boolean constant checks.
Alexandre Julliard
julliard at winehq.org
Mon Jun 12 16:10:39 CDT 2017
Module: wine
Branch: master
Commit: 82029cba2fcc49c39902f4ba3247c6216fdb9304
URL: http://source.winehq.org/git/wine.git/?a=commit;h=82029cba2fcc49c39902f4ba3247c6216fdb9304
Author: Matteo Bruni <mbruni at codeweavers.com>
Date: Fri Jun 9 21:19:38 2017 +0200
d3dx9/tests: Add a comment about the negation in boolean constant checks.
Signed-off-by: Matteo Bruni <mbruni at codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard at winehq.org>
---
dlls/d3dx9_36/tests/effect.c | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/dlls/d3dx9_36/tests/effect.c b/dlls/d3dx9_36/tests/effect.c
index 20da3c6..d75c5ce 100644
--- a/dlls/d3dx9_36/tests/effect.c
+++ b/dlls/d3dx9_36/tests/effect.c
@@ -4350,6 +4350,8 @@ static void test_effect_preshader_compare_pbool_consts_(unsigned int line, IDire
{
for (i = 0; i < ARRAY_SIZE(test_effect_preshader_bconsts); ++i)
{
+ /* The negation on both sides is actually needed, sometimes you
+ * get 0xffffffff instead of 1 on native. */
ok_(__FILE__, line)(!bdata[i] == !test_effect_preshader_bconsts[i],
"Pixel shader boolean constants do not match, expected %#x, got %#x, i %u.\n",
test_effect_preshader_bconsts[i], bdata[i], i);
@@ -4362,6 +4364,8 @@ static void test_effect_preshader_compare_pbool_consts_(unsigned int line, IDire
if (const_updated_mask[i / TEST_EFFECT_BITMASK_BLOCK_SIZE]
& (1u << (i % TEST_EFFECT_BITMASK_BLOCK_SIZE)))
{
+ /* The negation on both sides is actually needed, sometimes
+ * you get 0xffffffff instead of 1 on native. */
ok_(__FILE__, line)(!bdata[i] == !test_effect_preshader_bconsts[i],
"Pixel shader boolean constants do not match, expected %#x, got %#x, i %u, parameter %s.\n",
test_effect_preshader_bconsts[i], bdata[i], i, updated_param);
More information about the wine-cvs
mailing list