Paul Gofman : d3dx9: Remove redundant parameter size check in set_constants().

Alexandre Julliard julliard at winehq.org
Tue Jun 27 17:19:07 CDT 2017


Module: wine
Branch: master
Commit: ed7e27ad8db2c08afbf222d80ec0d6d093ad4498
URL:    http://source.winehq.org/git/wine.git/?a=commit;h=ed7e27ad8db2c08afbf222d80ec0d6d093ad4498

Author: Paul Gofman <gofmanp at gmail.com>
Date:   Thu Jun 22 16:11:54 2017 +0300

d3dx9: Remove redundant parameter size check in set_constants().

Signed-off-by: Paul Gofman <gofmanp at gmail.com>
Signed-off-by: Matteo Bruni <mbruni at codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard at winehq.org>

---

 dlls/d3dx9_36/preshader.c | 5 -----
 1 file changed, 5 deletions(-)

diff --git a/dlls/d3dx9_36/preshader.c b/dlls/d3dx9_36/preshader.c
index 7ca0c8f..3b06f66 100644
--- a/dlls/d3dx9_36/preshader.c
+++ b/dlls/d3dx9_36/preshader.c
@@ -1181,11 +1181,6 @@ static void set_constants(struct d3dx_regstore *rs, struct d3dx_const_tab *const
                         param_offset = i + j * info.major;
                     else
                         param_offset = i * info.minor + j;
-                    if (param_offset * sizeof(unsigned int) >= param->bytes)
-                    {
-                        WARN("Parameter data is too short, name %s, component %u.\n", debugstr_a(param->name), i);
-                        break;
-                    }
                     out[offset] = data[param_offset];
                 }
             }




More information about the wine-cvs mailing list