Francois Gouget : winetest/gather: Add the test unit and group or tag to the tooltips.

Alexandre Julliard julliard at winehq.org
Mon Mar 27 04:22:16 CDT 2017


Module: tools
Branch: master
Commit: ffc8c08773c4e6c213ef4648949afd4fca6d7776
URL:    http://source.winehq.org/git/tools.git/?a=commit;h=ffc8c08773c4e6c213ef4648949afd4fca6d7776

Author: Francois Gouget <fgouget at codeweavers.com>
Date:   Fri Mar 24 03:32:44 2017 +0100

winetest/gather: Add the test unit and group or tag to the tooltips.

The platform result pages can have quite a lot of columns so it is
easy to lose track of the test unit a line corresponds to.
Similarly the index pages have a lot of lines so it is easy to lose
track of which group or tag a column corresponds to.
So add this information to the cell tooltips.

Signed-off-by: Francois Gouget <fgouget at codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard at winehq.org>

---

 winetest/gather | 14 ++++++++------
 1 file changed, 8 insertions(+), 6 deletions(-)

diff --git a/winetest/gather b/winetest/gather
index 9680fbb..42460da 100755
--- a/winetest/gather
+++ b/winetest/gather
@@ -506,16 +506,17 @@ sub singletest($$$) {
     my ($group, $testname, $groupname) = @_;
     my $result = $group->{$testname};
 
-    my ($class, $msg, $title, $mouseover, $href, $label);
+    my ($msg, $prefix, $mouseover, $href, $label);
     if ($group->{reports} and @{$group->{reports}} > 1)
     {
         $href = $result->{omit} ? "" : "index_$group->{name}.html#$testname";
-        $label = $groupname;
+        $label = $prefix = $groupname;
     }
     else
     {
         my $report = $group->{reports} ? $group->{reports}->[0] : $group;
         $label = "$groupname $report->{tag}";
+        $prefix = "$testname | $report->{tag}";
         if (-r "$datadir/$build/$report->{dir}/$testname.html")
         {
             $href = "$report->{dir}/$testname.html";
@@ -526,8 +527,8 @@ sub singletest($$$) {
         }
     }
 
-    $class = get_result_class( $result );
-    $title = get_result_title( $testname, $result );
+    my $class = get_result_class( $result );
+    my $title = get_result_title( $testname, $result );
 
     my $status = $result->{status};
     if ($status eq "run")
@@ -576,14 +577,15 @@ sub singletest($$$) {
                $status =~ /^-/ ? "crashed" :
                $status eq "258" ? "timeout": "failed";
     }
+    $title = join(" | ", $prefix, $title);
     printf OUT "      <td class=\"%s\"><a %s %s %s>%s</a></td>\n",
                 $class, $href ? "href=\"$href\"" : "",
-                $title ? "title=\"$title\"" : "", $mouseover || "", $msg;
+                "title=\"$title\"", $mouseover || "", $msg;
     if ($group->{reports})
     {
         printf SUMMARY "%s %s <td class=\"%s\"><a %s %s %s>%s</a></td>\n",
                        $testname, $groupname, $class, $href ? "href=\"../$build/$href\"" : "",
-                       $title ? "title=\"$title\"" : "", $mouseover || "", $msg;
+                       "title=\"$title\"", $mouseover || "", $msg;
     }
 }
 




More information about the wine-cvs mailing list