Nikolay Sivov : comctl32/taskdialog: Remove superfluous title pointer check (Coverity).

Alexandre Julliard julliard at winehq.org
Mon May 1 16:38:04 CDT 2017


Module: wine
Branch: master
Commit: b1d46e0b5fb9a0b1f20291cb2bf7fa159bf10816
URL:    http://source.winehq.org/git/wine.git/?a=commit;h=b1d46e0b5fb9a0b1f20291cb2bf7fa159bf10816

Author: Nikolay Sivov <nsivov at codeweavers.com>
Date:   Sun Apr 30 22:16:22 2017 +0300

comctl32/taskdialog: Remove superfluous title pointer check (Coverity).

Signed-off-by: Nikolay Sivov <nsivov at codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard at winehq.org>

---

 dlls/comctl32/taskdialog.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/dlls/comctl32/taskdialog.c b/dlls/comctl32/taskdialog.c
index 6b8bcfc..e452d34 100644
--- a/dlls/comctl32/taskdialog.c
+++ b/dlls/comctl32/taskdialog.c
@@ -271,8 +271,7 @@ static DLGTEMPLATE *create_taskdialog_template(const TASKDIALOGCONFIG *taskconfi
     title_size = (strlenW(titleW) + 1) * sizeof(WCHAR);
 
     size = sizeof(DLGTEMPLATE) + 2 * sizeof(WORD);
-    if (titleW)
-        size += title_size;
+    size += title_size;
     size += 2; /* font size */
 
     list_init(&desc.controls);




More information about the wine-cvs mailing list