Akihiro Sagawa : midimap: Avoid using isdigit() for WCHARs.

Alexandre Julliard julliard at winehq.org
Tue May 16 16:05:11 CDT 2017


Module: wine
Branch: master
Commit: 2b0d9b56535dadd118610b7a1d6734216f7e4820
URL:    http://source.winehq.org/git/wine.git/?a=commit;h=2b0d9b56535dadd118610b7a1d6734216f7e4820

Author: Akihiro Sagawa <sagawa.aki at gmail.com>
Date:   Wed May 17 00:00:10 2017 +0900

midimap: Avoid using isdigit() for WCHARs.

Found with Coccinelle.

Signed-off-by: Akihiro Sagawa <sagawa.aki at gmail.com>
Signed-off-by: Alexandre Julliard <julliard at winehq.org>

---

 dlls/midimap/midimap.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/dlls/midimap/midimap.c b/dlls/midimap/midimap.c
index c7b8da3..64b4dc8 100644
--- a/dlls/midimap/midimap.c
+++ b/dlls/midimap/midimap.c
@@ -116,14 +116,15 @@ static BOOL	MIDIMAP_FindPort(const WCHAR* name, unsigned* dev)
 	    return TRUE;
     }
     /* try the form #nnn */
-    if (*name == '#' && isdigit(name[1]))
+    if (*name == '#' && name[1] >= '0' && name[1] <= '9')
     {
         const WCHAR*  ptr = name + 1;
         *dev = 0;
         do 
         {
             *dev = *dev * 10 + *ptr - '0';
-        } while (isdigit(*++ptr));
+            ptr++;
+        } while (*ptr >= '0' && *ptr <= '9');
 	if (*dev < numMidiOutPorts)
 	    return TRUE;
     }




More information about the wine-cvs mailing list