Francois Gouget : testbot: Remove unused VM filtering and counting functions.

Alexandre Julliard julliard at winehq.org
Tue Oct 3 02:43:56 CDT 2017


Module: tools
Branch: master
Commit: 050ffc835057b890df25552f36da1dbf829a02ea
URL:    http://source.winehq.org/git/tools.git/?a=commit;h=050ffc835057b890df25552f36da1dbf829a02ea

Author: Francois Gouget <fgouget at codeweavers.com>
Date:   Tue Oct  3 03:25:35 2017 +0200

testbot: Remove unused VM filtering and counting functions.

They have not been used since the last scheduler changes.

Signed-off-by: Francois Gouget <fgouget at codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard at winehq.org>

---

 testbot/lib/WineTestBot/VMs.pm | 59 ------------------------------------------
 1 file changed, 59 deletions(-)

diff --git a/testbot/lib/WineTestBot/VMs.pm b/testbot/lib/WineTestBot/VMs.pm
index 1fd72ff..dafce67 100644
--- a/testbot/lib/WineTestBot/VMs.pm
+++ b/testbot/lib/WineTestBot/VMs.pm
@@ -480,25 +480,6 @@ sub Status($;$)
   return $NewStatus;
 }
 
-sub HasPoweredOnStatus($)
-{
-  my ($self) = @_;
-  my $Status = $self->Status;
-  return ($Status eq "reverting" or
-          $Status eq "sleeping" or
-          $Status eq "idle" or
-          $Status eq "running");
-}
-
-sub HasEnabledRole($)
-{
-  my ($self) = @_;
-  my $Role = $self->Role;
-  return ($Role eq "extra" or
-          $Role eq "base" or
-          $Role eq "winetest");
-}
-
 sub Validate($)
 {
   my ($self) = @_;
@@ -628,46 +609,6 @@ sub CreateVMs(;$)
                                  \@PropertyDescriptors, $ScopeObject);
 }
 
-sub CountRevertingRunningVMs($)
-{
-  my ($self) = @_;
-
-  my $RevertingVMs = 0;
-  my $RunningVMs = 0;
-
-  foreach my $VM (@{$self->GetItems()})
-  {
-    my $VMStatus = $VM->Status;
-    if ($VMStatus eq "reverting")
-    {
-      $RevertingVMs++;
-    }
-    elsif ($VMStatus eq "running")
-    {
-      $RunningVMs++;
-    }
-  }
-
-  return ($RevertingVMs, $RunningVMs);
-}
-
-sub CountPoweredOnNonBaseVMs($)
-{
-  my ($self) = @_;
-
-  my $PoweredOnVMs = 0;
-  foreach my $VM (@{$self->GetItems()})
-  {
-    if ($VM->Role ne "base" and $VM->HasEnabledRole() and
-        $VM->HasPoweredOnStatus())
-    {
-      $PoweredOnVMs++;
-    }
-  }
-
-  return $PoweredOnVMs;
-}
-
 sub SortKeysBySortOrder($$)
 {
   my ($self, $Keys) = @_;




More information about the wine-cvs mailing list