Fabian Maurer : inetcomm: In SMTPTransport_ParseResponse remove unneeded statement (cppcheck).

Alexandre Julliard julliard at winehq.org
Tue Oct 3 15:39:53 CDT 2017


Module: wine
Branch: master
Commit: 6641efad7d8de1f36f5235a343c8cf9a8609b34e
URL:    http://source.winehq.org/git/wine.git/?a=commit;h=6641efad7d8de1f36f5235a343c8cf9a8609b34e

Author: Fabian Maurer <dark.shadow4 at web.de>
Date:   Tue Oct  3 17:37:26 2017 +0200

inetcomm: In SMTPTransport_ParseResponse remove unneeded statement (cppcheck).

Signed-off-by: Fabian Maurer <dark.shadow4 at web.de>
Signed-off-by: Alexandre Julliard <julliard at winehq.org>

---

 dlls/inetcomm/smtptransport.c | 8 +-------
 1 file changed, 1 insertion(+), 7 deletions(-)

diff --git a/dlls/inetcomm/smtptransport.c b/dlls/inetcomm/smtptransport.c
index c88ac9c..af11308 100644
--- a/dlls/inetcomm/smtptransport.c
+++ b/dlls/inetcomm/smtptransport.c
@@ -59,13 +59,7 @@ static HRESULT SMTPTransport_ParseResponse(SMTPTransport *This, char *pszRespons
     pResponse->rIxpResult.pszResponse = pszResponse;
     pResponse->rIxpResult.dwSocketError = 0;
     pResponse->rIxpResult.uiServerError = strtol(pszResponse, &pszResponse, 10);
-    if (*pszResponse == '-')
-    {
-        pResponse->fDone = FALSE;
-        pszResponse++;
-    }
-    else
-        pResponse->fDone = TRUE;
+    pResponse->fDone = (*pszResponse != '-');
 
     switch (pResponse->rIxpResult.uiServerError)
     {




More information about the wine-cvs mailing list