Piotr Caban : user32: Don't invalidate ComboBox on CB_SETCURSEL message.

Alexandre Julliard julliard at winehq.org
Fri Oct 6 14:58:53 CDT 2017


Module: wine
Branch: master
Commit: 1a114c9f4bab60463189e3ecb89766d4d2017d53
URL:    http://source.winehq.org/git/wine.git/?a=commit;h=1a114c9f4bab60463189e3ecb89766d4d2017d53

Author: Piotr Caban <piotr at codeweavers.com>
Date:   Wed Oct  4 12:38:47 2017 +0200

user32: Don't invalidate ComboBox on CB_SETCURSEL message.

Signed-off-by: Piotr Caban <piotr at codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard at winehq.org>

---

 dlls/user32/combo.c     | 5 +----
 dlls/user32/tests/msg.c | 2 +-
 2 files changed, 2 insertions(+), 5 deletions(-)

diff --git a/dlls/user32/combo.c b/dlls/user32/combo.c
index ee9ce0a..149a495 100644
--- a/dlls/user32/combo.c
+++ b/dlls/user32/combo.c
@@ -2142,10 +2142,7 @@ LRESULT ComboWndProc_common( HWND hwnd, UINT message, WPARAM wParam, LPARAM lPar
 	            SendMessageW(lphc->hWndLBox, LB_SETTOPINDEX, wParam, 0);
 
 		/* no LBN_SELCHANGE in this case, update manually */
-		if( lphc->wState & CBF_EDIT )
-		    CBUpdateEdit( lphc, (INT)wParam );
-		else
-		    InvalidateRect(lphc->self, &lphc->textRect, TRUE);
+                CBPaintText( lphc, NULL );
 		lphc->wState &= ~CBF_SELCHANGE;
 	        return  lParam;
 	case CB_GETLBTEXT:
diff --git a/dlls/user32/tests/msg.c b/dlls/user32/tests/msg.c
index 1d34fd2..1b4f6fa 100644
--- a/dlls/user32/tests/msg.c
+++ b/dlls/user32/tests/msg.c
@@ -6937,7 +6937,7 @@ static void test_combobox_messages(void)
     log_all_parent_messages++;
     SendMessageA(combo, CB_SETCURSEL, 0, 0);
     log_all_parent_messages--;
-    ok_sequence(SetCurSelComboSeq, "CB_SETCURSEL on a ComboBox", TRUE);
+    ok_sequence(SetCurSelComboSeq, "CB_SETCURSEL on a ComboBox", FALSE);
 
     DestroyWindow(combo);
     DestroyWindow(parent);




More information about the wine-cvs mailing list