Francois Gouget : testbot: Queued Tasks are not supposed to have a child process.

Alexandre Julliard julliard at winehq.org
Thu Oct 12 02:28:25 CDT 2017


Module: tools
Branch: master
Commit: 97299c59adcb1dc5cdb7c0e666184a24d4c54841
URL:    http://source.winehq.org/git/tools.git/?a=commit;h=97299c59adcb1dc5cdb7c0e666184a24d4c54841

Author: Francois Gouget <fgouget at codeweavers.com>
Date:   Wed Oct 11 16:17:33 2017 +0200

testbot: Queued Tasks are not supposed to have a child process.

So just silently unset ChildPid in Task::UpdateStatus() if needed, like
we do for the tasks in other states that should not have a child
process. Since they are queued they will get run later on anyway.

Signed-off-by: Francois Gouget <fgouget at codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard at winehq.org>

---

 testbot/lib/WineTestBot/Tasks.pm | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/testbot/lib/WineTestBot/Tasks.pm b/testbot/lib/WineTestBot/Tasks.pm
index b4298fb..3dd5f13 100644
--- a/testbot/lib/WineTestBot/Tasks.pm
+++ b/testbot/lib/WineTestBot/Tasks.pm
@@ -159,7 +159,7 @@ sub UpdateStatus($$)
   if (defined $self->ChildPid && !kill(0, $self->ChildPid) && $! == ESRCH)
   {
     $self->ChildPid(undef);
-    if ($Status eq "queued" || $Status eq "running")
+    if ($Status eq "running")
     {
       my ($JobId, $StepNo, $TaskNo) = @{$self->GetMasterKey()};
       my $OldUMask = umask(002);




More information about the wine-cvs mailing list