Jacek Caban : mshtml: Don't use fire_event to dispatch help event.

Alexandre Julliard julliard at winehq.org
Fri Oct 20 15:09:37 CDT 2017


Module: wine
Branch: master
Commit: 2a771127cda45a3ea50c98072a8f5c831168d9b5
URL:    http://source.winehq.org/git/wine.git/?a=commit;h=2a771127cda45a3ea50c98072a8f5c831168d9b5

Author: Jacek Caban <jacek at codeweavers.com>
Date:   Fri Oct 20 15:10:04 2017 +0200

mshtml: Don't use fire_event to dispatch help event.

Signed-off-by: Jacek Caban <jacek at codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard at winehq.org>

---

 dlls/mshtml/htmlelem.c | 13 ++++++++++---
 1 file changed, 10 insertions(+), 3 deletions(-)

diff --git a/dlls/mshtml/htmlelem.c b/dlls/mshtml/htmlelem.c
index 8aab4c4..9f231f5 100644
--- a/dlls/mshtml/htmlelem.c
+++ b/dlls/mshtml/htmlelem.c
@@ -5188,10 +5188,17 @@ HRESULT HTMLElement_handle_event(HTMLDOMNode *iface, DWORD eid, nsIDOMEvent *eve
 
             nsIDOMKeyEvent_GetKeyCode(key_event, &code);
 
-            switch(code) {
-            case VK_F1: /* DOM_VK_F1 */
+            if(code == VK_F1 /* DOM_VK_F1 */) {
+                DOMEvent *help_event;
+                HRESULT hres;
+
                 TRACE("F1 pressed\n");
-                fire_event(This->node.doc, EVENTID_HELP, TRUE, &This->node.event_target, NULL);
+
+                hres = create_document_event(This->node.doc, EVENTID_HELP, &help_event);
+                if(SUCCEEDED(hres)) {
+                    fire_event_obj(&This->node.event_target, help_event);
+                    IDOMEvent_Release(&help_event->IDOMEvent_iface);
+                }
                 *prevent_default = TRUE;
             }
 




More information about the wine-cvs mailing list